AclBehavior handel plugin name #944

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants
@zoghal
Contributor

zoghal commented Nov 8, 2012

AclBehavior support of plugin name when model is inside a plugin

@markstory

This comment has been minimized.

Show comment Hide comment
@markstory

markstory Nov 9, 2012

Member

Would you normally have models with the same name between plugins + app dir?

I worry that this change will break applications when people upgrade. Any existing dbacl trees will need to be manually migrated or the names stored in the existing database will no longer match the conditions being used.

Member

markstory commented Nov 9, 2012

Would you normally have models with the same name between plugins + app dir?

I worry that this change will break applications when people upgrade. Any existing dbacl trees will need to be manually migrated or the names stored in the existing database will no longer match the conditions being used.

@zoghal

This comment has been minimized.

Show comment Hide comment
@zoghal

zoghal Nov 9, 2012

Contributor

Basically there is no problem.
This is when we use this behavior in a Plugin models.

To use and access the Plugin models, you need to use Plugin name + model name.
(refrence : http://book.cakephp.org/2.0/en/plugins.html#plugin-models )

In the past, programmers had to manually do it. And this behavior will not be used.
(example : https://github.com/QuickAppsCMS/QuickApps-CMS/blob/1.1/QuickApps/Plugin/User/Model/Role.php )

Contributor

zoghal commented Nov 9, 2012

Basically there is no problem.
This is when we use this behavior in a Plugin models.

To use and access the Plugin models, you need to use Plugin name + model name.
(refrence : http://book.cakephp.org/2.0/en/plugins.html#plugin-models )

In the past, programmers had to manually do it. And this behavior will not be used.
(example : https://github.com/QuickAppsCMS/QuickApps-CMS/blob/1.1/QuickApps/Plugin/User/Model/Role.php )

@ceeram

This comment has been minimized.

Show comment Hide comment
@ceeram

ceeram Nov 19, 2012

Member

-1 for this, i dont see the need to add plugin prefixes. You can use the behavior fine with plugin models.

Member

ceeram commented Nov 19, 2012

-1 for this, i dont see the need to add plugin prefixes. You can use the behavior fine with plugin models.

@zoghal zoghal closed this Nov 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment