Use bytcode sequence for unicode ellipsis #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The codepoint for "horizontal ellipsis" is 0x2026, which enables a more robust display of that character on different systems.
|
you accidently committed something else, as well. |
|
Yeah, I always forget that github uses branches, not commits, for pull requests. Makes sense, I don't. |
markstory
added a commit
that referenced
this pull request
Nov 9, 2012
Use bytcode sequence for unicode ellipsis Fixes #3356
|
Perhaps the display issue is because those are console outputs but the test cases surely need to be updated. |
|
I updated my cake repo yesterday and noticed this issue, was going to check out the cause but saw this come up. This commit has fixed it for me |
|
I'll take a look as I merged that change in. |
|
I had a commit locally that addressed the tests but completely forgot about it. Who needs test cases anyway? ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The codepoint for "horizontal ellipsis" is 0x2026, which enables a more
robust display of that character on different systems.
With my setup here (Firefox, Linux, Helvetica) ellipsis was not displayed correctly (replaced by a question mark indicating a missing character).
I'm not entirely sure about all that UTF stuff, but this should likely work on most modern systems I guess.