Skip to content

Use bytcode sequence for unicode ellipsis #945

Merged
merged 1 commit into from Nov 9, 2012

5 participants

@aleho
aleho commented Nov 9, 2012

The codepoint for "horizontal ellipsis" is 0x2026, which enables a more
robust display of that character on different systems.

With my setup here (Firefox, Linux, Helvetica) ellipsis was not displayed correctly (replaced by a question mark indicating a missing character).

I'm not entirely sure about all that UTF stuff, but this should likely work on most modern systems I guess.

Alexander Hofbauer Use bytcode sequence for unicode ellipsis
The codepoint for "horizontal ellipsis" is 0x2026, which enables a more
robust display of that character on different systems.
c7fda56
@dereuromark
CakePHP member

you accidently committed something else, as well.

@aleho
aleho commented Nov 9, 2012

Yeah, I always forget that github uses branches, not commits, for pull requests. Makes sense, I don't.

@markstory markstory merged commit 7e00be8 into cakephp:2.3 Nov 9, 2012
@ADmad
CakePHP member
ADmad commented Nov 9, 2012

This PR causes failed tests case. The character code used seems to actually cause more display problems as seen here and here.

@ADmad
CakePHP member
ADmad commented Nov 9, 2012

Perhaps the display issue is because those are console outputs but the test cases surely need to be updated.

@dogmatic69

I updated my cake repo yesterday and noticed this issue, was going to check out the cause but saw this come up. This commit has fixed it for me

@markstory
CakePHP member

I'll take a look as I merged that change in.

@aleho
aleho commented Nov 10, 2012

I had a commit locally that addressed the tests but completely forgot about it. Who needs test cases anyway? ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.