Reorder arguments in some assertions #9621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
dereuromark
reviewed
Oct 17, 2016
| $this->assertEquals(Inflector::pluralize('sweet_potato'), 'sweet_potatoes'); | ||
| $this->assertEquals('sweet potatoes', Inflector::pluralize('sweet potato')); | ||
| $this->assertEquals('sweet-potatoes', Inflector::pluralize('sweet-potato')); | ||
| $this->assertEquals('sweet_potatoes', Inflector::pluralize('sweet_potato')); |
There was a problem hiding this comment.
Would be nice to also switch to assertSame() here, but no big deal.
Current coverage is 94.93% (diff: 100%)@@ master #9621 diff @@
==========================================
Files 414 414
Lines 28471 28471
Methods 3404 3404
Messages 0 0
Branches 0 0
==========================================
- Hits 27032 27030 -2
- Misses 1439 1441 +2
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in the
InflectorTestclass that the arguments in some of the assertion calls were in the incorrect order. While this obviously doesn't cause failure, it's not semantically correct, and consistency in programming is usually nice. This PR fixes the cases that I found.