New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9848 PaginatorComponent.php ignores maxLimit #9849

Merged
merged 5 commits into from Dec 7, 2016

Conversation

Projects
None yet
6 participants
@gorogoroyasu
Contributor

gorogoroyasu commented Dec 7, 2016

Fixes #9848

@gorogoroyasu gorogoroyasu referenced this pull request Dec 7, 2016

Closed

maxLimit is ignored in PaginatorComponent.php #9848

1 of 3 tasks complete
@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Dec 7, 2016

Current coverage is 94.91% (diff: 100%)

Merging #9849 into master will increase coverage by 0.18%

@@             master      #9849   diff @@
==========================================
  Files           415        415          
  Lines         28535      28597    +62   
  Methods        3407       3415     +8   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          27031      27142   +111   
+ Misses         1504       1455    -49   
  Partials          0          0          

Powered by Codecov. Last update bff449a...e521dbc

codecov-io commented Dec 7, 2016

Current coverage is 94.91% (diff: 100%)

Merging #9849 into master will increase coverage by 0.18%

@@             master      #9849   diff @@
==========================================
  Files           415        415          
  Lines         28535      28597    +62   
  Methods        3407       3415     +8   
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          27031      27142   +111   
+ Misses         1504       1455    -49   
  Partials          0          0          

Powered by Codecov. Last update bff449a...e521dbc

@chinpei215

This comment has been minimized.

Show comment
Hide comment
@chinpei215

chinpei215 Dec 7, 2016

Member

@gorogoroyasu Sorry, but I changed the description, as it was a message template.

Member

chinpei215 commented Dec 7, 2016

@gorogoroyasu Sorry, but I changed the description, as it was a message template.

@chinpei215 chinpei215 added this to the 3.3.10 milestone Dec 7, 2016

@markstory markstory merged commit f188cf8 into cakephp:master Dec 7, 2016

5 checks passed

codecov/patch 100% of diff hit (target 94.91%)
Details
codecov/project 94.92% (+0.01%) compared to 125e833
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment