Added ConfigReaderInterface::dump() and made all readers' dump() method ... #992

Merged
merged 1 commit into from Nov 30, 2012

Conversation

Projects
None yet
2 participants
@ADmad
Member

ADmad commented Nov 29, 2012

...support 'Plugin.keyname' format for keys

Refs 3363

+ * @param array $data The data to dump.
+ * @return boolean True on success or false on failure.
+ */
+ public function dump($key, $data);

This comment has been minimized.

Show comment Hide comment
@markstory

markstory Nov 30, 2012

Owner

Should this be added? It will make config adapters that used to work in 2.2 no longer work in 2.3.

@markstory

markstory Nov 30, 2012

Owner

Should this be added? It will make config adapters that used to work in 2.2 no longer work in 2.3.

This comment has been minimized.

Show comment Hide comment
@ADmad

ADmad Nov 30, 2012

Member

Since both our core readers have dump() and Configure::dump() does no checks before trying to call a reader's dump() method whether the method actually exists, I thought it would be best to add this method to the interface. We can document this in the migration guide. People using custom readers would be a very small minority anyway.

@ADmad

ADmad Nov 30, 2012

Member

Since both our core readers have dump() and Configure::dump() does no checks before trying to call a reader's dump() method whether the method actually exists, I thought it would be best to add this method to the interface. We can document this in the migration guide. People using custom readers would be a very small minority anyway.

This comment has been minimized.

Show comment Hide comment
@markstory

markstory Nov 30, 2012

Owner

I guess there are probably not many custom readers out there, as long as we document it well I'm ok with the interface change.

@markstory

markstory Nov 30, 2012

Owner

I guess there are probably not many custom readers out there, as long as we document it well I'm ok with the interface change.

This comment has been minimized.

Show comment Hide comment
@ADmad

ADmad Nov 30, 2012

Member

I will ensure the docs are properly updated :)

@ADmad

ADmad Nov 30, 2012

Member

I will ensure the docs are properly updated :)

@markstory

This comment has been minimized.

Show comment Hide comment
@markstory

markstory Nov 30, 2012

Owner

Other than the change in the interface this looks good to me.

Owner

markstory commented Nov 30, 2012

Other than the change in the interface this looks good to me.

Added ConfigReaderInterface::dump() and made all readers' dump() meth…
…od support 'Plugin.keyname' format for keys. Closes #3363

@ADmad ADmad merged commit 2bc5988 into cakephp:2.3 Nov 30, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment