New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cakephp/cakephp from require. Add orm and cache #308

Merged
merged 1 commit into from Mar 21, 2017

Conversation

Projects
None yet
6 participants
@harikt
Contributor

harikt commented Mar 21, 2017

Hi,

I have removed cakephp/cakephp from require and moved to require-dev , this helps to use it as a standalone without installing cakephp framework itself.

Thank you.

@harikt harikt referenced this pull request Mar 21, 2017

Closed

Cache or Clear tables. #309

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Mar 21, 2017

Codecov Report

Merging #308 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files          33       33           
  Lines        1782     1782           
=======================================
  Hits         1532     1532           
  Misses        250      250

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0f313...d874ecb. Read the comment docs.

codecov-io commented Mar 21, 2017

Codecov Report

Merging #308 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files          33       33           
  Lines        1782     1782           
=======================================
  Hits         1532     1532           
  Misses        250      250

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0f313...d874ecb. Read the comment docs.

},
"require-dev": {
"phpunit/phpunit": "~4.1",
"cakephp/cakephp": "~3.2",

This comment has been minimized.

@dereuromark

dereuromark Mar 21, 2017

Member

Does mixing the splits and core actually work? Is it necessary then?

@dereuromark

dereuromark Mar 21, 2017

Member

Does mixing the splits and core actually work? Is it necessary then?

This comment has been minimized.

@harikt

harikt Mar 21, 2017

Contributor

@dereuromark probably I didn't understand what you mean. Can you tell me what split are you telling and what is necessary ?

@harikt

harikt Mar 21, 2017

Contributor

@dereuromark probably I didn't understand what you mean. Can you tell me what split are you telling and what is necessary ?

This comment has been minimized.

@harikt

harikt Mar 21, 2017

Contributor

I have been re-reading your comment and guess what you mean is do we really need cakephp/cakephp itself in require-dev.

If so yes, we need for the test make use of the cakephp tests .

Regarding your comment :

Does mixing the splits and core actually work?

Yes, this is working for there is replace https://github.com/cakephp/cakephp/blob/83a94c084012eac0145b48c95a386f3417139167/composer.json#L61-L75 .

The only requirement for people to use migration is orm and cache. ie it.

@harikt

harikt Mar 21, 2017

Contributor

I have been re-reading your comment and guess what you mean is do we really need cakephp/cakephp itself in require-dev.

If so yes, we need for the test make use of the cakephp tests .

Regarding your comment :

Does mixing the splits and core actually work?

Yes, this is working for there is replace https://github.com/cakephp/cakephp/blob/83a94c084012eac0145b48c95a386f3417139167/composer.json#L61-L75 .

The only requirement for people to use migration is orm and cache. ie it.

@ADmad

This comment has been minimized.

Show comment
Hide comment
@ADmad

ADmad Mar 21, 2017

Member

LGTM

Member

ADmad commented Mar 21, 2017

LGTM

@lorenzo lorenzo merged commit 978bef8 into cakephp:master Mar 21, 2017

4 checks passed

codecov/patch Coverage not affected when comparing bc0f313...d874ecb
Details
codecov/project 85.97% remains the same compared to bc0f313
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
stickler-ci No lint errors found.
@lorenzo

This comment has been minimized.

Show comment
Hide comment
@lorenzo

lorenzo Mar 21, 2017

Member

Thanks @harikt

Member

lorenzo commented Mar 21, 2017

Thanks @harikt

@harikt harikt deleted the harikt:standalone branch Mar 21, 2017

@HavokInspiration HavokInspiration modified the milestone: 1.6.8 Jun 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment