Remove cakephp/cakephp from require. Add orm and cache#308
Conversation
Codecov Report
@@ Coverage Diff @@
## master #308 +/- ##
=======================================
Coverage 85.97% 85.97%
=======================================
Files 33 33
Lines 1782 1782
=======================================
Hits 1532 1532
Misses 250 250Continue to review full report at Codecov.
|
| }, | ||
| "require-dev": { | ||
| "phpunit/phpunit": "~4.1", | ||
| "cakephp/cakephp": "~3.2", |
There was a problem hiding this comment.
Does mixing the splits and core actually work? Is it necessary then?
There was a problem hiding this comment.
@dereuromark probably I didn't understand what you mean. Can you tell me what split are you telling and what is necessary ?
There was a problem hiding this comment.
I have been re-reading your comment and guess what you mean is do we really need cakephp/cakephp itself in require-dev.
If so yes, we need for the test make use of the cakephp tests .
Regarding your comment :
Does mixing the splits and core actually work?
Yes, this is working for there is replace https://github.com/cakephp/cakephp/blob/83a94c084012eac0145b48c95a386f3417139167/composer.json#L61-L75 .
The only requirement for people to use migration is orm and cache. ie it.
|
LGTM |
|
Thanks @harikt |
Hi,
I have removed
cakephp/cakephpfrom require and moved to require-dev , this helps to use it as a standalone without installing cakephp framework itself.Thank you.