Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cakephp/cakephp from require. Add orm and cache #308

Merged
merged 1 commit into from Mar 21, 2017
Merged

Remove cakephp/cakephp from require. Add orm and cache #308

merged 1 commit into from Mar 21, 2017

Conversation

harikt
Copy link
Contributor

@harikt harikt commented Mar 21, 2017

Hi,

I have removed cakephp/cakephp from require and moved to require-dev , this helps to use it as a standalone without installing cakephp framework itself.

Thank you.

@harikt harikt mentioned this pull request Mar 21, 2017
@codecov-io
Copy link

codecov-io commented Mar 21, 2017

Codecov Report

Merging #308 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #308   +/-   ##
=======================================
  Coverage   85.97%   85.97%           
=======================================
  Files          33       33           
  Lines        1782     1782           
=======================================
  Hits         1532     1532           
  Misses        250      250

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc0f313...d874ecb. Read the comment docs.

},
"require-dev": {
"phpunit/phpunit": "~4.1",
"cakephp/cakephp": "~3.2",
Copy link
Member

@dereuromark dereuromark Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does mixing the splits and core actually work? Is it necessary then?

Copy link
Contributor Author

@harikt harikt Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dereuromark probably I didn't understand what you mean. Can you tell me what split are you telling and what is necessary ?

Copy link
Contributor Author

@harikt harikt Mar 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been re-reading your comment and guess what you mean is do we really need cakephp/cakephp itself in require-dev.

If so yes, we need for the test make use of the cakephp tests .

Regarding your comment :

Does mixing the splits and core actually work?

Yes, this is working for there is replace https://github.com/cakephp/cakephp/blob/83a94c084012eac0145b48c95a386f3417139167/composer.json#L61-L75 .

The only requirement for people to use migration is orm and cache. ie it.

@ADmad
Copy link
Member

ADmad commented Mar 21, 2017

LGTM

@lorenzo lorenzo merged commit 978bef8 into cakephp:master Mar 21, 2017
@lorenzo
Copy link
Member

lorenzo commented Mar 21, 2017

Thanks @harikt

@harikt harikt deleted the standalone branch Mar 21, 2017
@HavokInspiration HavokInspiration modified the milestone: 1.6.8 Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants