Skip to content

Cache rebased#312

Merged
lorenzo merged 4 commits into
cakephp:masterfrom
harikt:cache-rebased
Apr 3, 2017
Merged

Cache rebased#312
lorenzo merged 4 commits into
cakephp:masterfrom
harikt:cache-rebased

Conversation

@harikt

@harikt harikt commented Mar 23, 2017

Copy link
Copy Markdown
Contributor

For #309

{
$this
->setName('orm-cache-build')
->setDescription('Build all metadata caches for the connection. If a table name is provided, only that table will be cached.')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line exceeds 120 characters; contains 138 characters

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wished if the @stickler-ci could fix it than complaining.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markstory not a bad idea ^

{
$this
->setName('orm-cache-clear')
->setDescription('Clear all metadata caches for the connection. If a table name is provided, only that table will be removed.')

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line exceeds 120 characters; contains 139 characters

@codecov-io

Copy link
Copy Markdown

Codecov Report

Merging #312 into master will increase coverage by 0.1%.
The diff coverage is 88.73%.

@@            Coverage Diff            @@
##           master     #312     +/-   ##
=========================================
+ Coverage   85.97%   86.07%   +0.1%     
=========================================
  Files          33       36      +3     
  Lines        1782     1853     +71     
=========================================
+ Hits         1532     1595     +63     
- Misses        250      258      +8
Impacted Files Coverage Δ
src/MigrationsDispatcher.php 100% <100%> (ø) ⬆️
src/Util/SchemaTrait.php 57.14% <57.14%> (ø)
src/Command/CacheBuild.php 96.15% <96.15%> (ø)
src/Command/CacheClear.php 96.55% <96.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 978bef8...bd06673. Read the comment docs.

@harikt

harikt commented Mar 29, 2017

Copy link
Copy Markdown
Contributor Author

Is there anything I can do to make this merge ?

@lorenzo

lorenzo commented Apr 3, 2017

Copy link
Copy Markdown
Member

I'll merge now but not doing a release until I confirm it does not create a big conflict with the shells provided by the cake core

@lorenzo
lorenzo merged commit b708eed into cakephp:master Apr 3, 2017
@lorenzo

lorenzo commented Apr 3, 2017

Copy link
Copy Markdown
Member

@harikt thanks so much!!

@harikt
harikt deleted the cache-rebased branch April 3, 2017 15:38
@harikt

harikt commented Apr 3, 2017

Copy link
Copy Markdown
Contributor Author

@lorenzo thank you for merging this.

I confirm it does not create a big conflict with the shells provided by the cake core

I don't believe so. But you can test things before the release :-) .

thanks so much!!

You are very welcome. And thank you once again for the merge. I hate to see PR's waiting for days :-) .

@HavokInspiration HavokInspiration modified the milestone: 1.6.8 Jun 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants