Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRFC - Rename project #9
Comments
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
So many cool suggestions! +1 for Backburner |
This comment has been minimized.
This comment has been minimized.
|
+1 for Batch and +1/2 for Backburner :) |
This comment has been minimized.
This comment has been minimized.
|
Procastinator |
This comment has been minimized.
This comment has been minimized.
|
Async |
This comment has been minimized.
This comment has been minimized.
|
I would go simple and use the same pattern for core modules like
Wouldnt be too bad as namespace. Maybe also the internal Queue namespace could be made more specific instead? Like
https://github.com/cakephp/queue/blob/master/src/Queue/QueueExtension.php#L31 Queue as a subnamespace is usually a bit generic anyways :) |
This comment has been minimized.
This comment has been minimized.
|
In fact queues implements asyncronous calls pattern. So I dont understand negative reaction about Async idea, at least i more talkaive then Deffered. |
This comment has been minimized.
This comment has been minimized.
When reading about the semantic difference:
Similar things could be said about a queue: The tasks are all async, true. |
This comment has been minimized.
This comment has been minimized.
|
Cake\Queue is a direct and clear namespace, this avoid multiple instances of the same word, which seems to be the main issue. |
This comment has been minimized.
This comment has been minimized.
|
Based on the suggested list +1 for Batch |
This comment has been minimized.
This comment has been minimized.
|
Empilhadeira |
This comment has been minimized.
This comment has been minimized.
|
I like Backburner, and would like to add Dawdle |
This comment has been minimized.
This comment has been minimized.
|
Echeleon or Kyoo or Kyu |
This comment has been minimized.
This comment has been minimized.
|
Queue is fine for me, but if we have to change it I like DelayedJob and JobRunner. |
This comment has been minimized.
This comment has been minimized.
|
I really don't want to make up a funky name. I've had enough of that in the past - I've even created a few bad plugin names myself - and it confuses what exactly the code is supposed to do. None of the official plugins have a "fun" name, so we shouldn't try to do that here either. That said, if folks want a new name, thats also fine with me. |
This comment has been minimized.
This comment has been minimized.
|
leaving in 'Backburner' expresses the idea well in Portuguese. |
This comment has been minimized.
This comment has been minimized.
This is a class I would like to rename if we keep
What about bake, and debugkit |
This comment has been minimized.
This comment has been minimized.
|
TaskDispenser |
This comment has been minimized.
This comment has been minimized.
|
@markstory those are grandfathered in :P
|
This comment has been minimized.
This comment has been minimized.
|
Surprised there are few suggestions that stay on theme. Baker Not saying any/all of those are good. But they are fun and play with the Cake theme. And can all be justified to mean queue / ‘taking steps’ / ‘doing things in sequence’ |
This comment has been minimized.
This comment has been minimized.
|
Fun name: BackBurner Irrespective of the name I would prefer |
This comment has been minimized.
This comment has been minimized.
|
Tasker - short and clear. |
This comment has been minimized.
This comment has been minimized.
|
I vote Async or Deferred or just use a derivative of Queue like Enqueue as mentioned above. As this will be an official library a fancy name like BackBurner is too non-descriptive and a bit lame tbh ;-) |
This comment has been minimized.
This comment has been minimized.
|
I also strongly prefer a functional name above a fun name, as the latter obfuscates meaning. Personally I see nothing wrong with Queue, as that is exactly what it is. Perhaps it could be If I absolutely have to pick from the provided options, I would go with @ADmad 's improvement of JobRunner: JobQueue/JobRunner |
This comment has been minimized.
This comment has been minimized.
|
Functional names are for people who can't read code/documentation :D |
This comment has been minimized.
This comment has been minimized.
|
@Zwartpet I see what you did there |
This comment has been minimized.
This comment has been minimized.
|
I like 'Conveyer'. It helps communicate that we're moving work somewhere else and hits a good balance of fun and literal. My concern with Async/deferred is that those terms have very clear meanings in adjacent technologies. They are used in Javascript, python and golang to mean something quite different than what this code does. |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
|
I don't know that seeing "Conveyer" on the sidebar in the docs will tell me enough to know that Cake supports queuing. |
This comment has been minimized.
This comment has been minimized.
|
Seeing just "queue" doesn't tell you either that it's a job queue. There are other queues too, for eg. the middleware queue. |
This comment has been minimized.
This comment has been minimized.
|
Please something simple and clear that expresses what it is:
Especially names like "async" and "deffered" make me think it's a promise / async library but clearly not a queue. |
A few folks in the cakephp-dev channel have commented that the
queuename is a bit generic and results in the project having classnames with multiple instances of the same word e.gQueue\Queue\QueueExtension.I'd like to discuss some alternate names that we could use. The goal of the rename would be to better communicate the problem or solution space of the plugin and be less literal about the underlying technology used.
Given that the plugin is going to focus on background jobs and delayed/deferred task execution, some candidates are: