New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove file-icons integration #13

Open
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@michaelbaudino

michaelbaudino commented Jun 23, 2017

The current file-icons integration has 3 bugs:

  1. the icon is not displayed for Solidity files
  2. the icon is not colorized for Solidity files
  3. the font is broken for the Ruby files

Before this PR:
before

This PR fixes all 3 issues.

After this PR:
after

@Alhadis

This comment has been minimized.

Alhadis commented Aug 1, 2017

Maintainer of file-icons here. =) It might please you to know that the file-icons package now supports Solidity files with a dedicated icon, as of v2.1.8 (which was actually released 3 days after this PR was submitted, haha).

Solidity

If there are any file-extensions that are missing, please don't hesitate to open an issue or submit a pull-request. =)

@michaelbaudino michaelbaudino changed the title from Fix file-icons integration to Remove file-icons integration Aug 1, 2017

@michaelbaudino

This comment has been minimized.

michaelbaudino commented Aug 1, 2017

@Alhadis Thanks for notification 🎩

@caktux I updated this PR to simply not define any style... the one from file-icons will be used and it looks like this:

screenshot-solidity-icons

@Alhadis

This comment has been minimized.

Alhadis commented Aug 1, 2017

You're most perfectly welcome, mate. :)

@Alhadis Alhadis referenced this pull request Mar 1, 2018

Closed

Text rendering is altered #708

@Alhadis

This comment has been minimized.

Alhadis commented Mar 1, 2018

@caktux Is this repository still maintained?

Alhadis added a commit to file-icons/atom that referenced this pull request May 19, 2018

Update troubleshooting docs to explain #739
It's unlikely caktux/language-ethereum#13 will ever be merged, since the
package appears well-and-truly abandoned by its author.

References: #708, #718
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment