New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for cordova 8 #2

Merged
merged 2 commits into from Jan 6, 2018

Conversation

Projects
None yet
2 participants
@TomTasche
Contributor

TomTasche commented Dec 31, 2017

thanks for this great plugin, it took me quite some time to figure out how to fix the viewport problem until i found your plugin!

path to source changed

@cakuki

This comment has been minimized.

Show comment
Hide comment
@cakuki

cakuki Jan 4, 2018

Owner

Thank you very much for the fix @TomTasche!

I will have to change your solution a bit to support Cordova 7.x in few days. As I don't want to drop support too soon. If you are willing to do that I'd be glad to merge too.

Owner

cakuki commented Jan 4, 2018

Thank you very much for the fix @TomTasche!

I will have to change your solution a bit to support Cordova 7.x in few days. As I don't want to drop support too soon. If you are willing to do that I'd be glad to merge too.

@TomTasche

This comment has been minimized.

Show comment
Hide comment
@TomTasche

TomTasche Jan 6, 2018

Contributor

good point @cakuki, see my last commit. i actually wanted to implement this with a version check of the current cordova version, but it seemed a lot easier to just check for the existence of the file...

Contributor

TomTasche commented Jan 6, 2018

good point @cakuki, see my last commit. i actually wanted to implement this with a version check of the current cordova version, but it seemed a lot easier to just check for the existence of the file...

@cakuki cakuki merged commit 06e5008 into cakuki:master Jan 6, 2018

@cakuki

This comment has been minimized.

Show comment
Hide comment
@cakuki

cakuki Jan 6, 2018

Owner

Thank you very much for your efforts!

Owner

cakuki commented Jan 6, 2018

Thank you very much for your efforts!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment