[mobile] support non-numeric passwords #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to always hide the built-in qtvirtualkeyboard to support using a different keyboard. Related: https://gitlab.com/postmarketOS/postmarketos-ondev/-/issues/47
Prepare to add a config option to allow non-numeric passwords, by giving the existing default_pin screen the more generic name user_pass. Adjust the title of the screen too. "default" in the file name was referring to configuring the default user's PIN/password as opposed to the SSH user. However, I think replacing it with "user" makes it more intuitive.
Change "cannot be typed in at boot time" to "can possibly not be typed in after installation" and explain that the same check is now used for the user password too.
Fix the condition in the while loop, so that it can actually continue with the "continue" keyword. Without this patch, having the sshd feature disabled would result in the fsType feature getting displayed, even if it was disabled.
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this pull request
May 2, 2021
Apply patches from the following MR, as they are required by postmarketos-ondev 0.5.0. I wrote most of the upstream mobile module code and I'm confident that they will get merged with either no or little changes: calamares/calamares-extensions#14
Make it more readable as for-loop.
ollieparanoid
commented
May 9, 2021
|
@adriaandegroot: how about tagging a new release of calamares-extensions? :) EDIT: this PR is part of latest release 1.1.2 already, however, a new release would be good to have 718f73c. Thanks for adjusting the code btw! |
|
@ollieparanoid There's a 1.2.1 now. |
|
Thank you very much @adriaandegroot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interface Sxmo does not require a numeric password, so let's add an option that allows to disable the numeric password. Also there is work being done to allow non-numeric passwords in Phosh (phosh!801).
While at it, add an option to disable the built-in virtual keyboard and fix a bug I found while developing this, navNextFeature wasn't able to skip more than one disabled feature at the same time.
Find details in the commit messages.
CC: @adriaandegroot, @Undef-a