Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
CAL may delete partitions during disk-probe #1044
Describe the bug
Back then I tested further and only found
Now in October a third user reports the same issue. In this case it got mounted in
Also this drive was formatted with ext4. This you can see on the session log. So I went ahead and did a full lengthy regression test with v18.0. Beside a small coding issue on my end I didn't found any regression. However, we seem to found the issue. Probably because it failed to umount and then QTemporaryDir deleted the contents automatically when the function returned. By default a mount is with rw rights. Auto-remove is on by default for: QTemporaryDir mountsDir; - doc.qt
Offending code exists since July-16 and got introduced with f2f5a18.
@adriaandegroot: do we need during disk probing write access to the drives? Seems when it fails to unmount data gets erased due to the functions of QTemporaryDir. Create random dir -> mount -> unmount -> destroy dir. We may miss some error check for unmounting drives ...
You wrote mountsDir.setAutoRemove( false ); twice.