New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAL-226: Support installing to existing LVM volumes #427

Closed
calamares-user opened this Issue May 10, 2015 · 22 comments

Comments

Projects
None yet
9 participants
@calamares-user

calamares-user commented May 10, 2015

Jira issue originally created by user edwardoo:

There is quite a bit of demand for LVM support, in part because:

  • LVM excels for more complex, multi-boot setups, and Calamares is used mainly by "smaller" distros, often installed beside "bigger" ones.
  • LVM is setup by Fedora's default partitioning scheme.
  • Once LVM is setup, it is a bit hard to shrink it to make room for non-lvm distros

Possible simplifications for a first version which would solve most of the complaints:

  • Support install to existing volumes only (people can use existing distro to do the setup)
  • Supporting it for / (root) only (home can be added to the fstab later)
  • Only support already mounted logical volumes

Basically, the idea is to have a possibility for experienced people to install Calamares-based distros when they have lvm. User-friendly support can come later.

PS: I just thought this should be tracked/prioritized here somewhere. Sorry if I'm wrong.

@calamares-user

This comment has been minimized.

Show comment
Hide comment
@calamares-user

calamares-user Jun 6, 2015

Comment created by philm:

Currently simply doesn't start if LVM volumes are present. At least there should be a message popping up, that we don't support it yet. Anyway, LVM will be addressed soon or later.

calamares-user commented Jun 6, 2015

Comment created by philm:

Currently simply doesn't start if LVM volumes are present. At least there should be a message popping up, that we don't support it yet. Anyway, LVM will be addressed soon or later.

@jcfrosty

This comment has been minimized.

Show comment
Hide comment
@jcfrosty

jcfrosty Aug 7, 2017

3.1.1 released, but still no true LVM support?

jcfrosty commented Aug 7, 2017

3.1.1 released, but still no true LVM support?

@stikonas

This comment has been minimized.

Show comment
Hide comment
@stikonas

stikonas Oct 27, 2017

Contributor

@jcfrosty there are now various pull requests that should make partitioning operations work on LVM LV volumes: #846 #828
After they land, other Calamares modules (probably bootloader and initramfs) will still need some work to add LVM support.

And lastly, LVM VG operations will have to be added, but that's beyond what this bug wants.

Note: kpmcore 3.3 have changed a bit how devices are scanned, so LVM volume groups will appear in the devices list. Still, it won't be functional until issues above are addressed.

Contributor

stikonas commented Oct 27, 2017

@jcfrosty there are now various pull requests that should make partitioning operations work on LVM LV volumes: #846 #828
After they land, other Calamares modules (probably bootloader and initramfs) will still need some work to add LVM support.

And lastly, LVM VG operations will have to be added, but that's beyond what this bug wants.

Note: kpmcore 3.3 have changed a bit how devices are scanned, so LVM volume groups will appear in the devices list. Still, it won't be functional until issues above are addressed.

@stikonas

This comment has been minimized.

Show comment
Hide comment
@stikonas

stikonas Dec 16, 2017

Contributor

I've now successfully installed onto preexisting LVM volume group (logical volumes were created by the installer).

Contributor

stikonas commented Dec 16, 2017

I've now successfully installed onto preexisting LVM volume group (logical volumes were created by the installer).

@philmmanjaro

This comment has been minimized.

Show comment
Hide comment
@philmmanjaro

philmmanjaro Dec 17, 2017

Member

Will test also on my end soon. The current CAL in unstable has the needed patches and is based on kpmcore v3.3.

Member

philmmanjaro commented Dec 17, 2017

Will test also on my end soon. The current CAL in unstable has the needed patches and is based on kpmcore v3.3.

@RafalSkolasinski

This comment has been minimized.

Show comment
Hide comment
@RafalSkolasinski

RafalSkolasinski Oct 14, 2018

Is it known when this functionality will roll out to distros using Calamares installer?
At least installing on created by hand LVM volumes.

RafalSkolasinski commented Oct 14, 2018

Is it known when this functionality will roll out to distros using Calamares installer?
At least installing on created by hand LVM volumes.

@stikonas

This comment has been minimized.

Show comment
Hide comment
@stikonas

stikonas Oct 14, 2018

Contributor

@RafalSkolasinski It should already be available. kpmcore 3.3. has now propagated to most distributions. Calamares more recently gained support for creating/removing LVM VGs too but maybe it's not yet in most distros.

Contributor

stikonas commented Oct 14, 2018

@RafalSkolasinski It should already be available. kpmcore 3.3. has now propagated to most distributions. Calamares more recently gained support for creating/removing LVM VGs too but maybe it's not yet in most distros.

@RafalSkolasinski

This comment has been minimized.

Show comment
Hide comment
@RafalSkolasinski

RafalSkolasinski Oct 14, 2018

I tried Solus installation not more than a week ago and installer didn't see any of my preexisting LVM volumes.
It was not a problem of linux system itself or driver as lvs was showing all of them properly.

Anyway, I really hope to see this feature out there soon :).

RafalSkolasinski commented Oct 14, 2018

I tried Solus installation not more than a week ago and installer didn't see any of my preexisting LVM volumes.
It was not a problem of linux system itself or driver as lvs was showing all of them properly.

Anyway, I really hope to see this feature out there soon :).

@stikonas

This comment has been minimized.

Show comment
Hide comment
@stikonas

stikonas Oct 14, 2018

Contributor

Maybe lvm was not installed on the live system?

Contributor

stikonas commented Oct 14, 2018

Maybe lvm was not installed on the live system?

@RafalSkolasinski

This comment has been minimized.

Show comment
Hide comment
@RafalSkolasinski

RafalSkolasinski Oct 14, 2018

RafalSkolasinski commented Oct 14, 2018

@stikonas

This comment has been minimized.

Show comment
Hide comment
@stikonas

stikonas Oct 14, 2018

Contributor

I downloaded Solus and it doesn't look like they use Calamares. Am I looking at the wrong place?

Contributor

stikonas commented Oct 14, 2018

I downloaded Solus and it doesn't look like they use Calamares. Am I looking at the wrong place?

@RafalSkolasinski

This comment has been minimized.

Show comment
Hide comment
@RafalSkolasinski

RafalSkolasinski Oct 14, 2018

Oh, you're probably right. I must had got confused and think that it is calamares it is using.
I am sorry to give you troubles!

I believe Manjaro and Sabayon are using Calamares?
I will be testing those two soon, with lvm setup. I will let you know if I will encounter any problems there.

RafalSkolasinski commented Oct 14, 2018

Oh, you're probably right. I must had got confused and think that it is calamares it is using.
I am sorry to give you troubles!

I believe Manjaro and Sabayon are using Calamares?
I will be testing those two soon, with lvm setup. I will let you know if I will encounter any problems there.

@Pointedstick

This comment has been minimized.

Show comment
Hide comment
@Pointedstick

Pointedstick Oct 14, 2018

If this feature has been implemented, shouldn't the issue be closed?

Pointedstick commented Oct 14, 2018

If this feature has been implemented, shouldn't the issue be closed?

@stikonas

This comment has been minimized.

Show comment
Hide comment
@stikonas

stikonas Oct 14, 2018

Contributor

If this feature has been implemented, shouldn't the issue be closed?

Yes, it should. When I added support to installing to existing LVM volumes, I still thought that we should keep it open until LVM VG operations are implemented. They were implemented in GSoC this year (althogh, I haven't tested Calamares after that). So now it should be closed. But I don't have permissions to close the bug.

Contributor

stikonas commented Oct 14, 2018

If this feature has been implemented, shouldn't the issue be closed?

Yes, it should. When I added support to installing to existing LVM volumes, I still thought that we should keep it open until LVM VG operations are implemented. They were implemented in GSoC this year (althogh, I haven't tested Calamares after that). So now it should be closed. But I don't have permissions to close the bug.

@Pointedstick

This comment has been minimized.

Show comment
Hide comment
@Pointedstick

Pointedstick commented Oct 15, 2018

Me neither. @adriaandegroot?

@adriaandegroot

This comment has been minimized.

Show comment
Hide comment
@adriaandegroot

adriaandegroot Oct 15, 2018

Contributor

LVM is something I leave entirely to people who know about it (e.g. @stikonas and @cjlcarvalho) and who want it. I have neither quality. If this is implemented (with latest kpmcore) and someone says so, I'll close the ticket.

Contributor

adriaandegroot commented Oct 15, 2018

LVM is something I leave entirely to people who know about it (e.g. @stikonas and @cjlcarvalho) and who want it. I have neither quality. If this is implemented (with latest kpmcore) and someone says so, I'll close the ticket.

@philmmanjaro

This comment has been minimized.

Show comment
Hide comment
@philmmanjaro

philmmanjaro Oct 15, 2018

Member

Normally it can be closed. However, I see the following patches not yet included in v3.2.2:

  • [partition] Fixing LVM LV name line edit visibility. - committed on 13 Aug
  • [partition] Don't show erase button for inactive RAID. - committed on 13 Aug
  • [partition] Disabling partition buttons for inactive RAID. - committed on 13 Aug
Member

philmmanjaro commented Oct 15, 2018

Normally it can be closed. However, I see the following patches not yet included in v3.2.2:

  • [partition] Fixing LVM LV name line edit visibility. - committed on 13 Aug
  • [partition] Don't show erase button for inactive RAID. - committed on 13 Aug
  • [partition] Disabling partition buttons for inactive RAID. - committed on 13 Aug
@stikonas

This comment has been minimized.

Show comment
Hide comment
@stikonas

stikonas Oct 15, 2018

Contributor

Well, there are more potential bugs (e.g. #888 is it still there?) But we can probably track them separately from this bug. No software is bug free anyway.

Contributor

stikonas commented Oct 15, 2018

Well, there are more potential bugs (e.g. #888 is it still there?) But we can probably track them separately from this bug. No software is bug free anyway.

@philmmanjaro

This comment has been minimized.

Show comment
Hide comment
@philmmanjaro

philmmanjaro Oct 15, 2018

Member

OK. I'm fine with closing this one. @adriaandegroot: maybe you add @stikonas as an CAL developer so he may support you in closing issues as needed.

Member

philmmanjaro commented Oct 15, 2018

OK. I'm fine with closing this one. @adriaandegroot: maybe you add @stikonas as an CAL developer so he may support you in closing issues as needed.

@adriaandegroot adriaandegroot added this to the v3.2.3 milestone Oct 15, 2018

@adriaandegroot

This comment has been minimized.

Show comment
Hide comment
@adriaandegroot

adriaandegroot Oct 15, 2018

Contributor

I'm marking it as Milestone 3.2.3 to indicate that it's available in v 3.2.3 .. those commits @philmmanjaro mentions are in master, waiting for the next release (which is waiting on the swap-UI stuff being finished).

Contributor

adriaandegroot commented Oct 15, 2018

I'm marking it as Milestone 3.2.3 to indicate that it's available in v 3.2.3 .. those commits @philmmanjaro mentions are in master, waiting for the next release (which is waiting on the swap-UI stuff being finished).

@philmmanjaro

This comment has been minimized.

Show comment
Hide comment
@philmmanjaro

philmmanjaro Oct 15, 2018

Member

@stikonas: for #888 I didn't had time yet to test the issue further. Personally I'm not using LVM at all. @adriaandegroot: alright. I'm already merging master to my packages anyway. It is always good for others to know and keep track on ongoing development 😃

Member

philmmanjaro commented Oct 15, 2018

@stikonas: for #888 I didn't had time yet to test the issue further. Personally I'm not using LVM at all. @adriaandegroot: alright. I'm already merging master to my packages anyway. It is always good for others to know and keep track on ongoing development 😃

@cjlcarvalho

This comment has been minimized.

Show comment
Hide comment
@cjlcarvalho

cjlcarvalho Oct 16, 2018

Contributor

I was planning to work on #888 some time ago. I can take a look at it.

Contributor

cjlcarvalho commented Oct 16, 2018

I was planning to work on #888 some time ago. I can take a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment