New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTRFS - volumes not correctly added to fstab #796

Closed
philmmanjaro opened this Issue Sep 11, 2017 · 6 comments

Comments

Projects
None yet
3 participants
@philmmanjaro
Member

philmmanjaro commented Sep 11, 2017

According to the german Youtube review it seems, that BTRFS volumes don't get properly added to fstab. I've to recreate the issue once more, to find some pointers on how to fix this ...

@abucodonosor

This comment has been minimized.

Show comment
Hide comment
@abucodonosor

abucodonosor Sep 12, 2017

Contributor

@philmmanjaro

to follow this guy is really HARD .. anyway he is funny :-)

I see what is wrong already .. you simple hit #797
( also the guy forgot to tell swap is missing too )

The problem we see is the following:

  • LANG being used is de_DE
  • /boot ext2 ( not translated )
  • / btrfs ( translated Btrfs but the check is different for root in is our modules )
  • swap swap ( translated Linux-Swap )

this is what we get back from KPMcore with his configuration:

"/dev/sda1" mtpoint: "/boot" fs: QVariant(QString, "ext2")
"/dev/sda2" mtpoint: "/" fs: QVariant(QString, "Btrfs")
"/dev/sda3" mtpoint: "" fs: QVariant(QString, "Linux-Swap")

And your bftrfs problems starting from there now:

https://github.com/calamares/calamares/blob/master/src/modules/fstab/main.py#L187

     if (partition["fs"] == "btrfs" .... <-- won't trigger since is now Btrfs

Same situation for swap also for sure swap was not written to grub.cfg

Also for sure LUKS installations are broken.

You can do a simple test for that..

Fire up any of your ISO in qemu/vbox in de_DE.. goto terminal

LC_ALL=C sudo -E calamares -d

Now open another tab , do a mount to see tmp_root_mount_point and chroot to there.
Wait installation finishes and cat etc/fstab .. all should be fine.

Do now the same with de_DE :)

A quick an dirty hack for now would be to have a small rm_function() in your
ISO creation script(s) and before you umount your rootfs image run it and
rm -rf all kpmcore locales so you have on your ISO just plain en_US for KPMcore.

I use something similar to workaround that for now since it break with a lot laguages.

I hope this helps you fixing that..

Contributor

abucodonosor commented Sep 12, 2017

@philmmanjaro

to follow this guy is really HARD .. anyway he is funny :-)

I see what is wrong already .. you simple hit #797
( also the guy forgot to tell swap is missing too )

The problem we see is the following:

  • LANG being used is de_DE
  • /boot ext2 ( not translated )
  • / btrfs ( translated Btrfs but the check is different for root in is our modules )
  • swap swap ( translated Linux-Swap )

this is what we get back from KPMcore with his configuration:

"/dev/sda1" mtpoint: "/boot" fs: QVariant(QString, "ext2")
"/dev/sda2" mtpoint: "/" fs: QVariant(QString, "Btrfs")
"/dev/sda3" mtpoint: "" fs: QVariant(QString, "Linux-Swap")

And your bftrfs problems starting from there now:

https://github.com/calamares/calamares/blob/master/src/modules/fstab/main.py#L187

     if (partition["fs"] == "btrfs" .... <-- won't trigger since is now Btrfs

Same situation for swap also for sure swap was not written to grub.cfg

Also for sure LUKS installations are broken.

You can do a simple test for that..

Fire up any of your ISO in qemu/vbox in de_DE.. goto terminal

LC_ALL=C sudo -E calamares -d

Now open another tab , do a mount to see tmp_root_mount_point and chroot to there.
Wait installation finishes and cat etc/fstab .. all should be fine.

Do now the same with de_DE :)

A quick an dirty hack for now would be to have a small rm_function() in your
ISO creation script(s) and before you umount your rootfs image run it and
rm -rf all kpmcore locales so you have on your ISO just plain en_US for KPMcore.

I use something similar to workaround that for now since it break with a lot laguages.

I hope this helps you fixing that..

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

@abucodonosor

This comment has been minimized.

Show comment
Hide comment
@abucodonosor

abucodonosor Sep 12, 2017

Contributor

@philmmanjaro

not really about that issue but found out btrfs is broken with luks+systemd .. leftover
from #730 .. will fix that in a bit

Contributor

abucodonosor commented Sep 12, 2017

@philmmanjaro

not really about that issue but found out btrfs is broken with luks+systemd .. leftover
from #730 .. will fix that in a bit

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

@philmmanjaro

This comment has been minimized.

Show comment
Hide comment
@philmmanjaro

philmmanjaro Sep 12, 2017

Member

@adriaandegroot & @stikonas: I've tested now my last changes. Seems to work now.

Member

philmmanjaro commented Sep 12, 2017

@adriaandegroot & @stikonas: I've tested now my last changes. Seems to work now.

@abucodonosor

This comment has been minimized.

Show comment
Hide comment
@abucodonosor

abucodonosor Sep 12, 2017

Contributor

@philmmanjaro
abucodonosor@457fa9f

( now your btrfs user should be happy )

Contributor

abucodonosor commented Sep 12, 2017

@philmmanjaro
abucodonosor@457fa9f

( now your btrfs user should be happy )

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 12, 2017

[modules] work on #797 and #796
- this is a workaround and might need to be reverted.
@adriaandegroot

This comment has been minimized.

Show comment
Hide comment
@adriaandegroot

adriaandegroot Sep 14, 2017

Contributor

Closing this one because I merged the stuff from @abucodonosor , and fixed the (un)translation of the fs names just now -- messing around in all the uses of the fs-label, instead of fixing it at the source, is patching symptoms instead of the cause.

Contributor

adriaandegroot commented Sep 14, 2017

Closing this one because I merged the stuff from @abucodonosor , and fixed the (un)translation of the fs names just now -- messing around in all the uses of the fs-label, instead of fixing it at the source, is patching symptoms instead of the cause.

@philmmanjaro

This comment has been minimized.

Show comment
Hide comment
@philmmanjaro

philmmanjaro Sep 14, 2017

Member

Yes, it makes totally sense.

Member

philmmanjaro commented Sep 14, 2017

Yes, it makes totally sense.

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 14, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 14, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 14, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 14, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 14, 2017

philmmanjaro added a commit to manjaro/calamares that referenced this issue Sep 14, 2017

@stikonas stikonas referenced this issue Sep 15, 2017

Closed

BTRFS LUKS #803

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment