Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for performing operations on LVM logical volumes. #828

merged 109 commits into from Dec 15, 2017


Copy link

@stikonas stikonas commented Oct 6, 2017

At the moment there is no UI to obtain LVM LV name, so it is hardcoded to rootfs

adriaandegroot and others added 13 commits Oct 3, 2017
use orphaned Branding::ProductLogo as sidebar image
- it doesn't make any sense to have restartNowCommand and fallback
  set to the same command.
- also fallback should be something generic every init supports
finished: use generic shutdown command

This comment has been minimized.

Copy link

@kkofler kkofler commented on src/branding/default/branding.desc in 1491a02 Oct 4, 2017

This can actually also be smaller. On my system, the window icon is shown as 18x18 in the top left corner of the window, and as 16x16 in the taskbar on my tiny panel.

Copy link
Collaborator Author

@stikonas stikonas commented Oct 6, 2017

Unfortunately, right now there is no GUI to obtain LV partition name. So I just added rootfs for testing.

Copy link
Collaborator Author

@stikonas stikonas commented Oct 6, 2017

Something similar is required for other jobs as well: ResizePartitionJob, DeletePartitionJob

Copy link

@adriaandegroot adriaandegroot commented Oct 9, 2017

Can we complete this, clean it up, and have something that isn't just for testing before merging it?

@stikonas stikonas force-pushed the stikonas:lvm2 branch from 7213a3e to 06c0534 Oct 9, 2017
Copy link
Collaborator Author

@stikonas stikonas commented Oct 9, 2017

Fixed LVM LV naming issue. But this will need some other changes in kpmcore (or calamares). KPMcore has protected access to some partition functions (in particular setPartitionPath). And since Calamares uses it's own jobs, we don't have access to setPartitionPath.

@stikonas stikonas force-pushed the stikonas:lvm2 branch from 06c0534 to 4912d8a Oct 9, 2017
In the timezone widget, locations in the far north -- Inuvik,
Thule, Longyearbyen -- were displayed too far south, because the
map location calculation assumes a linear gradient, which places
90 degrees north at about 70 degrees. Change calculation to
pretend the world is flat south of 62 degrees north, and then
'bend' the remaining 28 degrees of latitude to the top of the
image. This puts most places in the right spot, although Yellowknife
is now on the south shore of Great Slave.

Fort Nelson should be north of Dawson Creek, too -- the math still
needs a little work.

While here, put Antarctica in the south, otherwise Rothera keeps
showing up in Greenland.
Copy link
Collaborator Author

@stikonas stikonas commented Oct 9, 2017

This will need kpmcore 3.3. Then it will compile

abucodonosor and others added 25 commits Oct 30, 2017
- Warn here since it may not be what the Distributor want.
  Having wrong groups may result in broken permissions for
  created user.
- explain what defaultGroups is for in users.conf
RequirementsChecker.cpp: rearrange cDebug() output
 - KPMCore code moved
 - Small fixes
add qt crash handler and kate temp files to gitignore
Document users.conf
 - data has already been read, don't try to read more from the QNM reply
 - regression introduced in 7e25909
locale.conf: explain what all the settings are about
 - replace weird distinction between 3.0 and 3.2 by searching once
 - prefer 3.2
 - also look for suffixed versions (PythonXY) besides the Python3 suffix

FIXES #857
 - Document netinstall.conf a little,
 - Add setting *required* which influences whether next is enabled or not
   in case of missing or corrupt data,
 - Enable *next* button only once some (any!) data is received.

This can be used to disallow stepping past the netinstall step when
there is no data (e.g. internet has failed between the welcome page
and the netinstall page).
 - m_groups is only set to a non-nullptr value when data is received
   and fully processed,
 - avoid nullptr dereference when paging *back* from a netinstall
   page that hasn't loaded groups data.

FIXES #859
 - don't log when libs not found
 - log that it's the Python libraries version (not Python itself)
 - fix RE that was getting the wrong results for maj.min
@stikonas stikonas changed the title Fix create partition job to work with LVM devices. Add support for performing operations on LVM logical volumes. Nov 14, 2017
@adriaandegroot adriaandegroot merged commit 12deb67 into calamares:kpmcore-3.2 Dec 15, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
@stikonas stikonas deleted the stikonas:lvm2 branch Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

9 participants