fix: Install Stripe for team on team event type app page by joeauyeung · Pull Request #10920 · calcom/cal.diy

joeauyeung · 2023-08-24T00:43:52Z

What does this PR do?

This PR installs Stripe for a team if installed from that team's event type.

Fixes # (issue)

Requirement/Documentation

If there is a requirement document, please, share it here.
If there is ab UI/UX design document, please, share it here.

Type of change

Bug fix (non-breaking change which fixes an issue)

How should this be tested?

Create a team event type
Go to the apps page and install Stripe
After the OAuth flow, Stripe should be installed for that team

Mandatory Tasks

Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

I haven't added tests that prove my fix is effective or that my feature works
I haven't checked if new and existing unit tests pass locally with my changes

vercel · 2023-08-24T00:44:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
api	❌ Failed (Inspect)			Aug 28, 2023 4:54pm
cal	🔄 Building (Inspect)	Visit Preview	💬 Add feedback	Aug 28, 2023 4:54pm
cal-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 28, 2023 4:54pm
dev	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 28, 2023 4:54pm
ui	❌ Failed (Inspect)			Aug 28, 2023 4:54pm

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
qa	⬜️ Ignored (Inspect)	Visit Preview		Aug 28, 2023 4:54pm

github-actions · 2023-08-24T00:44:10Z

Thank you for following the naming conventions! 🙏

github-actions · 2023-08-24T00:50:18Z

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

deploysentinel · 2023-08-24T00:51:19Z

Current Playwright Test Results Summary

✅ 122 Passing - ⚠️ 5 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 08/28/2023 04:58:28pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 47968bc

Started: 08/28/2023 04:56:24pm UTC

⚠️ Flakes

📄 apps/web/playwright/reschedule.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Reschedule Tests Should be able to book slot that overlaps with original rescheduled booking Retry 1 • Initial Attempt	0% (0) 0 / 250 runs failed over last 7 days	2.80% (7) 7 / 250 runs flaked over last 7 days

📄 apps/web/playwright/event-types.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Event Types tests user can add multiple organizer address Retry 1 • Initial Attempt	0.40% (1) 1 / 252 run failed over last 7 days	4.76% (12) 12 / 252 runs flaked over last 7 days

📄 apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
FORM_SUBMITTED can submit a form and get a submission event Retry 1 • Initial Attempt	0% (0) 0 / 248 runs failed over last 7 days	24.19% (60) 60 / 248 runs flaked over last 7 days

📄 packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Routing Forms Seeded Routing Form Routing Link should validate fields Retry 1 • Initial Attempt	1.55% (4) 4 / 258 runs failed over last 7 days	7.36% (19) 19 / 258 runs flaked over last 7 days

📄 packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 1 Flake

Test Case Results

Test Case	Last 7 days Failures	Last 7 days Flakes
Popup Tests should be able to reschedule Retry 1 • Initial Attempt	0% (0) 0 / 256 runs failed over last 7 days	99.61% (255) 255 / 256 runs flaked over last 7 days

View Detailed Build Results

hariombalhara · 2023-08-24T08:00:52Z

        setRequirePayment(enabled);
-      }}>
+      }}
+      teamId={eventType.team?.id || undefined}>


Will it work for a managed event type? I have seen that for that we need to check for parent eventType's team.

Just tested and everything is disabled on children event types. The teamId is used for installing the credentials for that team.

hariombalhara

Left a comment for the confirmation, otherwise looks good.

CLAassistant · 2023-08-28T09:16:44Z

All committers have signed the CLA.

Changes were addressed.

Install Stripe on team from team event type

2657809

joeauyeung requested a review from a team August 24, 2023 00:43

joeauyeung self-assigned this Aug 24, 2023

zomars added the core area: core, team members only label Aug 24, 2023

vercel Bot deployed to Preview – ui August 24, 2023 00:45 View deployment

vercel Bot deployed to Preview – api August 24, 2023 00:47 View deployment

vercel Bot deployed to Preview – cal-demo August 24, 2023 00:50 View deployment

vercel Bot deployed to Preview – dev August 24, 2023 00:50 View deployment

joeauyeung marked this pull request as draft August 24, 2023 02:00

Merge branch 'main' into fix/install-stripe-on-eventtype-for-teams

4da646e

joeauyeung marked this pull request as ready for review August 24, 2023 02:06

vercel Bot had a problem deploying to Preview – ui August 24, 2023 02:10 Failure

vercel Bot deployed to Preview – api August 24, 2023 02:12 View deployment

vercel Bot deployed to Preview – dev August 24, 2023 02:14 View deployment

vercel Bot deployed to Preview – cal-demo August 24, 2023 02:15 View deployment

hariombalhara reviewed Aug 24, 2023

View reviewed changes

hariombalhara previously requested changes Aug 24, 2023

View reviewed changes

Merge branch 'main' into fix/install-stripe-on-eventtype-for-teams

47968bc

vercel Bot had a problem deploying to Preview – api August 28, 2023 16:50 Failure

vercel Bot had a problem deploying to Preview – ui August 28, 2023 16:50 Failure

vercel Bot deployed to Preview – dev August 28, 2023 16:54 View deployment

vercel Bot deployed to Preview – cal-demo August 28, 2023 16:54 View deployment

joeauyeung requested a review from hariombalhara August 28, 2023 17:09

alannnc approved these changes Aug 28, 2023

View reviewed changes

alannnc merged commit 2ee0ec1 into main Aug 28, 2023

alannnc deleted the fix/install-stripe-on-eventtype-for-teams branch August 28, 2023 23:39

Udit-takkar pushed a commit that referenced this pull request Aug 29, 2023

Install Stripe on team from team event type (#10920)

140842c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Install Stripe for team on team event type app page#10920

fix: Install Stripe for team on team event type app page#10920
alannnc merged 3 commits into
mainfrom
fix/install-stripe-on-eventtype-for-teams

joeauyeung commented Aug 24, 2023

Uh oh!

vercel Bot commented Aug 24, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 24, 2023 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 24, 2023 •

edited

Loading

Uh oh!

deploysentinel Bot commented Aug 24, 2023 •

edited

Loading

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Uh oh!

hariombalhara Aug 24, 2023

Uh oh!

joeauyeung Aug 28, 2023 •

edited

Loading

Uh oh!

hariombalhara left a comment

Uh oh!

CLAassistant commented Aug 28, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

joeauyeung commented Aug 24, 2023

What does this PR do?

Requirement/Documentation

Type of change

How should this be tested?

Mandatory Tasks

Checklist

Uh oh!

vercel Bot commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Next.js Bundle Analysis for @calcom/web

Uh oh!

deploysentinel Bot commented Aug 24, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current Playwright Test Results Summary

⚠️ Flakes

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Test Case Results

Uh oh!

hariombalhara Aug 24, 2023

Choose a reason for hiding this comment

Uh oh!

joeauyeung Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hariombalhara left a comment

Choose a reason for hiding this comment

Uh oh!

CLAassistant commented Aug 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

vercel Bot commented Aug 24, 2023 •

edited

Loading

github-actions Bot commented Aug 24, 2023 •

edited

Loading

github-actions Bot commented Aug 24, 2023 •

edited

Loading

deploysentinel Bot commented Aug 24, 2023 •

edited

Loading

joeauyeung Aug 28, 2023 •

edited

Loading

CLAassistant commented Aug 28, 2023 •

edited

Loading