Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: settings design match #14630

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

sean-brydon
Copy link
Member

A design match for settings from a 1-1 with @ciaranha

Fixed: CAL-2824

Fixed: #12866

@graphite-app graphite-app bot requested a review from a team April 17, 2024 10:47
Copy link
Contributor

github-actions bot commented Apr 17, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@dosubot dosubot bot added the 🧹 Improvements Improvements to existing features. Mostly UX/UI label Apr 17, 2024
@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync Stale ui area: UI, frontend, button, form, input ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work labels Apr 17, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Apr 17, 2024
Copy link

vercel bot commented Apr 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
platform-starter-kit ❌ Failed (Inspect) Apr 17, 2024 0:38am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 0:38am
cal ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 0:38am
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 17, 2024 0:38am

Copy link

graphite-app bot commented Apr 17, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (04/17/24)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

github-actions bot commented Apr 17, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link

deploysentinel bot commented Apr 17, 2024

Current Playwright Test Results Summary

✅ 302 Passing - ⚠️ 22 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/17/2024 12:55:19pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 0973393

Started: 04/17/2024 12:50:48pm UTC

⚠️ Flakes

📄   apps/web/playwright/managed-event-types.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Managed Event Types Can create managed event type
Retry 1Initial Attempt
0.37% (1) 1 / 272 run
failed over last 7 days
4.41% (12) 12 / 272 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- legacy user enabling recurring event comes with default options
Retry 1Initial Attempt
0% (0) 0 / 283 runs
failed over last 7 days
2.83% (8) 8 / 283 runs
flaked over last 7 days
Event Types tests -- legacy user Different Locations Tests Can remove location from multiple locations that are saved
Retry 1Initial Attempt
0% (0) 0 / 280 runs
failed over last 7 days
18.57% (52) 52 / 280 runs
flaked over last 7 days

📄   apps/web/playwright/login.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
user can login & logout succesfully -- future login flow user & logout using dashboard
Retry 2Retry 1Initial Attempt
5.07% (14) 14 / 276 runs
failed over last 7 days
33.70% (93) 93 / 276 runs
flaked over last 7 days

📄   apps/web/playwright/teams.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Teams - NonOrg -- future Team Onboarding Invite Members
Retry 2Retry 1Initial Attempt
6.85% (20) 20 / 292 runs
failed over last 7 days
37.67% (110) 110 / 292 runs
flaked over last 7 days
Teams - NonOrg -- legacy Can create a booking for Round Robin EventType
Retry 1Initial Attempt
0.34% (1) 1 / 293 run
failed over last 7 days
3.75% (11) 11 / 293 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can update a users email (verification enabled)
Retry 2Retry 1Initial Attempt
5.63% (16) 16 / 284 runs
failed over last 7 days
23.59% (67) 67 / 284 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Pending payment booking should not be confirmed by default
Retry 2Retry 1Initial Attempt
1.08% (3) 3 / 279 runs
failed over last 7 days
21.86% (61) 61 / 279 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 2Retry 1Initial Attempt
1.05% (3) 3 / 285 runs
failed over last 7 days
18.25% (52) 52 / 285 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/action-based.e2e.ts • 8 Flakes

Top 1 Common Error Messages

null

8 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Popup Tests should open embed iframe on click - Configured with light theme
Retry 1Initial Attempt
-0.36% (-1) -1 / 278 runs
failed over last 7 days
63.67% (177) 177 / 278 runs
flaked over last 7 days
Popup Tests should be able to reschedule
Retry 1Initial Attempt
-175.25% (-177) -177 / 101 runs
failed over last 7 days
175.25% (177) 177 / 101 runs
flaked over last 7 days
Popup Tests should open Routing Forms embed on click
Retry 1Initial Attempt
-175.25% (-177) -177 / 101 runs
failed over last 7 days
175.25% (177) 177 / 101 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when no theme is configured through Embed API
Retry 1Initial Attempt
-173.27% (-175) -175 / 101 runs
failed over last 7 days
174.26% (176) 176 / 101 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe according to system theme when configured with 'auto' theme using Embed API
Retry 1Initial Attempt
-176% (-176) -176 / 100 runs
failed over last 7 days
176% (176) 176 / 100 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Event Booking Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-176% (-176) -176 / 100 runs
failed over last 7 days
176% (176) 176 / 100 runs
flaked over last 7 days
Popup Tests Floating Button Popup Pro User - Configured in App with default setting of system theme should open embed iframe(Booker Profile Page) with dark theme when configured with dark theme using Embed API
Retry 1Initial Attempt
-176% (-176) -176 / 100 runs
failed over last 7 days
176% (176) 176 / 100 runs
flaked over last 7 days
Popup Tests prendered embed should be loaded and apply the config given to it
Retry 1Initial Attempt
-176% (-176) -176 / 100 runs
failed over last 7 days
176% (176) 176 / 100 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done nonexisting user is invited to Org
Retry 1Initial Attempt
0.35% (1) 1 / 284 run
failed over last 7 days
8.45% (24) 24 / 284 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 282 runs
failed over last 7 days
42.55% (120) 120 / 282 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0.35% (1) 1 / 282 run
failed over last 7 days
53.55% (151) 151 / 282 runs
flaked over last 7 days

📄   packages/app-store/routing-forms/playwright/tests/basic.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Routing Forms Seeded Routing Form Router URL should work
Retry 1Initial Attempt
0% (0) 0 / 281 runs
failed over last 7 days
8.90% (25) 25 / 281 runs
flaked over last 7 days

📄   apps/web/playwright/organization/booking.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Bookings Team Event Can create a booking for Round Robin EventType
Retry 1Initial Attempt
0.35% (1) 1 / 289 run
failed over last 7 days
3.81% (11) 11 / 289 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-04-17 at 4 59 04 PM

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consumer core area: core, team members only 🧹 Improvements Improvements to existing features. Mostly UX/UI Low priority Created by Linear-GitHub Sync ⚡ Quick Wins A collection of quick wins/quick fixes that are less than 30 minutes of work Stale ui area: UI, frontend, button, form, input
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-2824] Settings sidebar needs a UI update
4 participants