Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1518 #1521

Merged
merged 4 commits into from Jan 17, 2022
Merged

Fix for #1518 #1521

merged 4 commits into from Jan 17, 2022

Conversation

zomars
Copy link
Member

@zomars zomars commented Jan 14, 2022

What does this PR do?

Fixes #1518

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Try building app with GOOGLE_API_CREDENTIALS undefined.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code and corrected any misspellings
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Jan 14, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/cal/calendso/7SNiYTT25BSP2gf18Tx9dsYXUBMD
✅ Preview: https://calendso-git-fix-google-api-credentials-cal.vercel.app

@zomars zomars requested a review from PeerRich January 14, 2022 22:14
Copy link
Contributor

@deepakprabhakara deepakprabhakara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this was the one we were discussing yesterday but thought it was related to Github Actions and external PRs.

@zomars zomars added the ♻️ autoupdate tells kodiak to keep this branch up-to-date label Jan 14, 2022
@vercel vercel bot temporarily deployed to Preview January 14, 2022 23:28 Inactive
@vercel vercel bot temporarily deployed to Preview January 15, 2022 15:36 Inactive
@PeerRich PeerRich enabled auto-merge (squash) January 15, 2022 15:36
@vercel vercel bot temporarily deployed to Preview January 15, 2022 16:24 Inactive
@w3irdrobot
Copy link

Thoughts on why this wasn't automerged? I believe this would fix an issue with the Docker build as well.

@PeerRich
Copy link
Member

Thoughts on why this wasn't automerged? I believe this would fix an issue with the Docker build as well.

yeah it seems like this issue https://github.com/calendso/calendso/issues/1527 is blocking some automerges. Will force-merge now!

@PeerRich PeerRich merged commit 460dda6 into main Jan 17, 2022
@PeerRich PeerRich deleted the fix/google-api-credentials branch January 17, 2022 13:02
@krumware
Copy link
Member

This fixed the docker build. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ autoupdate tells kodiak to keep this branch up-to-date
Projects
None yet
5 participants