Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Booking Date Picker - First few dates are rendered fast, but later dates are all rendered in UI at once. #1989

Merged
merged 5 commits into from Feb 28, 2022
Merged

[Bugfix] Booking Date Picker - First few dates are rendered fast, but later dates are all rendered in UI at once. #1989

merged 5 commits into from Feb 28, 2022

Conversation

hariombalhara
Copy link
Member

@hariombalhara hariombalhara commented Feb 27, 2022

Fixes: First few dates are rendered fast, but later dates are all rendered in UI at once. Now a day is rendered at once.
Performance Improvement: Even on a 6x slowdown now, the Date Picker experience is much better.

Motivation: On my mobile device, Date Picker was still unusable for many seconds when switching months.

Desktop Before
desktop-before

Desktop After
desktop-after

6x Slowdown Before
6x slowdown before

6x Slowdown After
6x slowdown-after

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Performance Improvement

How should this be tested?

  • Browse through months in date picker back and forth.

Checklist

  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

- It allows DatePicker to work well even on 6x slowdown
- Looks better UX wise as every day is being updated and more predictable.
@vercel
Copy link

vercel bot commented Feb 27, 2022

@hariombalhara is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Feb 27, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

docs – ./apps/docs

🔍 Inspect: https://vercel.com/cal/docs/BAeRf4rfcxyMhPdfdbkPXzo8vnuB
✅ Preview: Canceled

[Deployment for 4100390 canceled]

calendso – ./apps/web

🔍 Inspect: https://vercel.com/cal/calendso/8etz3EEgMJ3QE4wDigAyf6tfE7kT
✅ Preview: https://calendso-git-fork-hariombalhara-fix-progressive-rene-695502-cal.vercel.app

@vercel vercel bot temporarily deployed to Preview – docs February 27, 2022 12:28 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 27, 2022 20:54 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 27, 2022 20:56 Inactive
@vercel vercel bot temporarily deployed to Preview – docs February 27, 2022 21:05 Inactive
Copy link
Contributor

@baileypumfleet baileypumfleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix! Looks good to me. Thank you very much for your contribution :)

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice iteration on your earlier contribution!

@vercel vercel bot temporarily deployed to Preview – docs February 27, 2022 23:59 Inactive
@vercel vercel bot temporarily deployed to Preview – calendso February 27, 2022 23:59 Inactive
@baileypumfleet baileypumfleet merged commit cc90cf0 into calcom:main Feb 28, 2022
@PeerRich PeerRich added the core area: core, team members only label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants