New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Booking Date Picker - First few dates are rendered fast, but later dates are all rendered in UI at once. #1989
[Bugfix] Booking Date Picker - First few dates are rendered fast, but later dates are all rendered in UI at once. #1989
Conversation
- It allows DatePicker to work well even on 6x slowdown - Looks better UX wise as every day is being updated and more predictable.
@hariombalhara is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). docs – ./apps/docs🔍 Inspect: https://vercel.com/cal/docs/BAeRf4rfcxyMhPdfdbkPXzo8vnuB [Deployment for 4100390 canceled] calendso – ./apps/web🔍 Inspect: https://vercel.com/cal/calendso/8etz3EEgMJ3QE4wDigAyf6tfE7kT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice fix! Looks good to me. Thank you very much for your contribution :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice iteration on your earlier contribution!
Fixes: First few dates are rendered fast, but later dates are all rendered in UI at once. Now a day is rendered at once.
Performance Improvement: Even on a 6x slowdown now, the Date Picker experience is much better.
Motivation: On my mobile device, Date Picker was still unusable for many seconds when switching months.
Desktop Before
Desktop After
6x Slowdown Before
6x Slowdown After
Type of change
How should this be tested?
Checklist