fix/stripe-customer-sync #3153
Merged
fix/stripe-customer-sync #3153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alannnc
commented
Jul 4, 2022
| }); | ||
|
|
||
| // Notify stripe about the change | ||
| if (updatedUser && updatedUser.metadata && hasKeyInMetadata(updatedUser, "stripeCustomerId")) { |
There was a problem hiding this comment.
@zomars Should I add the same flag to know if we are on self hosted? And don't execute any stripe code.
There was a problem hiding this comment.
Some self-hosted users will use Stripe Connect, If this is only for premium usernames then we can skip it
There was a problem hiding this comment.
Let me get this right, connect can be for self hosted users, but this it's only involves our user plan handling so I should add flag here for IS_SELF_HOSTED.
There was a problem hiding this comment.
Nevermind seems like is good to go 👍🏽
zomars
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Takes care of keeping in sync user data with stripe customer data
Fixes # (issue)
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist