Fixes translation issue of dynamic variables in workflows #4734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zomars
reviewed
Sep 28, 2022
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
emrysal
reviewed
Sep 29, 2022
| @@ -255,7 +255,7 @@ | |||
| "user_needs_to_confirm_or_reject_booking_recurring": "{{user}} muss noch die Terminreihe des wiederkehrenden Termins bestätigen oder ablehnen.", | |||
| "meeting_is_scheduled": "Dieser Termin ist geplant", | |||
| "meeting_is_scheduled_recurring": "Ihr wiederkehrender Termin wurde geplant", | |||
| "submitted": "Ihr Termin wurde gebuhct", | |||
| "submitted": "Ihr Termin wurde gebucht", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Variables with translations that have more than 2 words like nom de l'événement were falsely translated to
{NOM_DE L'ÉVÉNEMENT} instead of {NOM_DE_L'ÉVÉNEMENT}
With this PR all spaces get replaced with underscores and not just the first one.
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Checklist