Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes to booking page #4876

Merged
merged 4 commits into from Oct 6, 2022
Merged

fixes to booking page #4876

merged 4 commits into from Oct 6, 2022

Conversation

PeerRich
Copy link
Member

@PeerRich PeerRich commented Oct 6, 2022 •
edited

fixed line break for checkbox on booking page and removed event type URL from profile page

closes #4872

CleanShot 2022-10-06 at 13 35 09@2x

__

before:

CleanShot 2022-10-06 at 13 37 09@2x

after:

CleanShot 2022-10-06 at 13 34 32@2x

CleanShot 2022-10-06 at 13 34 54@2x

@PeerRich PeerRich linked an issue Oct 6, 2022 that may be closed by this pull request
hide page title on event-types #4873
Closed
@vercel
Copy link

vercel bot commented Oct 6, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cal ❌ Failed (Inspect) Oct 6, 2022 at 2:27PM (UTC)

@PeerRich PeerRich changed the title fixed line break for checkbox on booking page and removed event type … fixes to booking page Oct 6, 2022
@PeerRich PeerRich mentioned this pull request Oct 6, 2022
Closed
1 task
@PeerRich PeerRich enabled auto-merge (squash) October 6, 2022 13:14
baileypumfleet
baileypumfleet reviewed Oct 6, 2022
View reviewed changes
Copy link
Contributor

@baileypumfleet baileypumfleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code changes are fine but not sure on submodules

emrysal
emrysal approved these changes Oct 6, 2022
View reviewed changes
Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PeerRich PeerRich merged commit 7900f8b into main Oct 6, 2022
@PeerRich PeerRich deleted the 4873-hide-page-title-on-event-types-1 branch October 6, 2022 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileypumfleet baileypumfleet baileypumfleet left review comments

@emrysal emrysal emrysal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Cal.com Core Roadmap
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

hide page title on event-types There is no need to display this redundant information.
3 participants
@PeerRich @emrysal @baileypumfleet