Fixing rescheduled booking email date #5035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PeerRich
approved these changes
Oct 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The base email template assumes that if there is a "cancellationReason" text, it is a cancellation email striking out the date from the email. The thing is we also rely on that same variable to hold a rescheduling reason, which ends up sending a rescheduled booking email with a striked out date when it doesn't apply. This is intended to fix that for every email destinatary.
Before:
After:
Fixes # (issue)
Environment: Staging(main branch) / Production
Type of change
How should this be tested?
Try rescheduling a booking and receive an email as an attendee and organizer. The date should not be stricken out, whether you include a rescheduling reason or not.