Skip to content

perf: improve application toggle flow#8302

Merged
zomars merged 6 commits into
calcom:mainfrom
anonrig:perf-app-toggle
Apr 18, 2023
Merged

perf: improve application toggle flow#8302
zomars merged 6 commits into
calcom:mainfrom
anonrig:perf-app-toggle

Conversation

@anonrig
Copy link
Copy Markdown
Contributor

@anonrig anonrig commented Apr 15, 2023

This pull request includes some caching on translation logic. I've also added some TODOs for future reference.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
cal ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 1:45am
ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 1:45am

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 15, 2023

@anonrig is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Comment thread packages/trpc/server/routers/viewer/apps.tsx Outdated
Comment thread packages/trpc/server/routers/viewer/apps.tsx Outdated
Comment thread packages/trpc/server/routers/viewer/apps.tsx
@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps 162.74 KB 394.03 KB 112.58% (🟢 -0.85%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@zomars zomars self-requested a review as a code owner April 17, 2023 22:41
@zomars zomars requested a review from a team April 17, 2023 22:41
Copy link
Copy Markdown
Contributor

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some fixes, tested and LGTM to ship.

LGTM

@zomars zomars enabled auto-merge (squash) April 17, 2023 22:48
@zomars zomars added ♻️ autoupdate tells kodiak to keep this branch up-to-date automerge labels Apr 17, 2023
@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link
Copy Markdown
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Two Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/apps/[slug]/[...pages] 389.68 KB 620.97 KB 177.42% (🟡 +0.17%)
/auth/setup 82.16 KB 313.45 KB 89.56% (🟡 +0.16%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

Copy link
Copy Markdown
Contributor

@roae roae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zomars zomars merged commit ae22246 into calcom:main Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge ♻️ autoupdate tells kodiak to keep this branch up-to-date

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants