Skip to content

chore: upgrade TypeScript to v5.9 - #22861

Merged
emrysal merged 1 commit into
mainfrom
chore/typescript-5-9
Aug 1, 2025
Merged

chore: upgrade TypeScript to v5.9#22861
emrysal merged 1 commit into
mainfrom
chore/typescript-5-9

Conversation

@eunjae-lee

Copy link
Copy Markdown
Contributor

What does this PR do?

  • Fixes #XXXX (GitHub issue number)
  • Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

  • Show screen recordings of the issue or feature.
  • Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

  • Add side-by-side screenshots of the original and updated change.
  • Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@coderabbitai

coderabbitai Bot commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

Caution

Review failed

The pull request is closed.

Walkthrough

The changes across the repository consist primarily of updating the TypeScript dependency from version ^5.7.2 (or ^5 in one case) to the beta version ^5.9.0-beta in the devDependencies or dependencies sections of multiple package.json files. One additional update is made to the eslint-config-next dependency in packages/config/package.json, changing its version from ^13.2.1 to ^15.4.5. There is also a minor code change in apps/web/app/api/logo/route.ts, where a buffer is explicitly cast to BodyInit when constructing a NextResponse. No changes were made to the declarations of exported or public entities.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa618db and ee9d32a.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (18)
  • apps/api/v1/package.json (1 hunks)
  • apps/api/v2/package.json (1 hunks)
  • apps/ui-playground/package.json (1 hunks)
  • apps/web/app/api/logo/route.ts (1 hunks)
  • apps/web/package.json (1 hunks)
  • package.json (1 hunks)
  • packages/app-store-cli/package.json (1 hunks)
  • packages/config/package.json (2 hunks)
  • packages/embeds/embed-core/package.json (1 hunks)
  • packages/embeds/embed-react/package.json (1 hunks)
  • packages/embeds/embed-snippet/package.json (1 hunks)
  • packages/eslint-plugin/package.json (1 hunks)
  • packages/lib/package.json (1 hunks)
  • packages/platform/atoms/package.json (1 hunks)
  • packages/platform/examples/base/package.json (1 hunks)
  • packages/platform/libraries/package.json (1 hunks)
  • packages/trpc/package.json (1 hunks)
  • packages/ui/package.json (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/typescript-5-9

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions

github-actions Bot commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

E2E results are ready!

@emrysal emrysal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! not a huge fan of beta modes but then again it's TS.

@emrysal
emrysal marked this pull request as ready for review August 1, 2025 14:16
@emrysal
emrysal requested review from a team as code owners August 1, 2025 14:16
@emrysal
emrysal requested a review from a team August 1, 2025 14:16
@emrysal
emrysal merged commit 28cb2cf into main Aug 1, 2025
81 of 85 checks passed
@emrysal
emrysal deleted the chore/typescript-5-9 branch August 1, 2025 14:16
@dosubot dosubot Bot added the ⬆️ dependencies Pull requests that update a dependency file label Aug 1, 2025
@eunjae-lee

Copy link
Copy Markdown
Contributor Author

@emrysal oh actually I didn't mean this to be merged. I wanted to test how much of work is needed to upgrade to 5.9 (turned out just a little).

but yeah, it's typescript. should be good to go with even beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only ⬆️ dependencies Pull requests that update a dependency file ready-for-e2e

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants