fix(apps/web): enhance JWT response with token type and expiration details - #24841
Merged
dhairyashiil merged 9 commits intoNov 9, 2025
Merged
Conversation
|
@zhyd1997 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Merged
15 tasks done
Contributor
E2E results are ready! |
anikdhabal
enabled auto-merge (squash)
November 3, 2025 15:39
Contributor
Author
|
Hi @volnei Thanks for your review, the failed e2e tests doesn’t related to the code changes in the pull request. |
Contributor
Author
|
Failed again, interesting! |
devin-ai-integration
Bot
force-pushed
the
fix/yadong-issue-24840-1761999763
branch
from
November 3, 2025 16:53
257059f to
8c2718f
Compare
auto-merge was automatically disabled
November 4, 2025 06:27
Head branch was pushed to by a user without write access
…id for unique email identifiers
Contributor
Author
|
CI passed finally ✅ |
dhairyashiil
approved these changes
Nov 9, 2025
akarsh-jain-790
pushed a commit
to akarsh-jain-790/cal.com
that referenced
this pull request
Mar 8, 2026
…tails (calcom#24841) * fix: enhance JWT response with token type and expiration details * fix: update email generation in createUsersFixture to use v4 UUID without dashes * revert: update email generation in createUsersFixture to use short-uuid for unique email identifiers --------- Co-authored-by: Anik Dhabal Babu <81948346+anikdhabal@users.noreply.github.com> Co-authored-by: Udit Takkar <53316345+Udit-takkar@users.noreply.github.com> Co-authored-by: Volnei Munhoz <volnei@cal.com> Co-authored-by: Dhairyashil Shinde <93669429+dhairyashiil@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
expires_infield — causes tokens to expire silently and403errors in third-party apps #24840 (GitHub issue number)Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
TODO:
PLEASE UPDATE THE DOC HERE:
https://cal.com/help/apps-and-integrations/oauth#access-token-request
Summary by cubic
Make the OAuth token endpoint RFC 6749 compliant by including token_type=bearer and expires_in=1800, and by adding no-store cache headers. Fixes clients failing to parse token type and expiry (CAL-6674, #24840).
Written for commit 435d34f. Summary will update automatically on new commits.