New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setDate function? #2
Comments
That sounds like a sensible change. A PR would be great!
… On May 27, 2019, at 5:06 AM, Jessica Stokes ***@***.***> wrote:
My use case involves updating the control’s displayed date based on a few factors, and I’m currently using the setup(withInitiallySelectedDate:) method, which works but has an overhead of having to repeat all the setup each time you update.
Would it be reasonable to either move the setup code to init and replace the current setup method with a setDate, or to add a setDate method which does just the date-setting stuff?
I’d be happy to put together a PR if either of these sound agreeable to you 😄
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
More specifically, I’m on board with adding a `setDate` function.
… On May 27, 2019, at 5:47 PM, Cal Stephens ***@***.***> wrote:
That sounds like a sensible change. A PR would be great!
> On May 27, 2019, at 5:06 AM, Jessica Stokes ***@***.***> wrote:
>
> My use case involves updating the control’s displayed date based on a few factors, and I’m currently using the setup(withInitiallySelectedDate:) method, which works but has an overhead of having to repeat all the setup each time you update.
>
> Would it be reasonable to either move the setup code to init and replace the current setup method with a setDate, or to add a setDate method which does just the date-setting stuff?
>
> I’d be happy to put together a PR if either of these sound agreeable to you 😄
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
|
Hi. |
Sure, I’m happy to review a PR if you make one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
My use case involves updating the control’s displayed date based on a few factors, and I’m currently using the
setup(withInitiallySelectedDate:)
method, which works but has an overhead of having to repeat all the setup each time you update.Would it be reasonable to either move the setup code to
init
and replace the currentsetup
method with asetDate
, or to add asetDate
method which does just the date-setting stuff?I’d be happy to put together a PR if either of these sound agreeable to you 😄
The text was updated successfully, but these errors were encountered: