Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setDate function? #2

Closed
ticky opened this issue May 27, 2019 · 4 comments
Closed

setDate function? #2

ticky opened this issue May 27, 2019 · 4 comments

Comments

@ticky
Copy link

ticky commented May 27, 2019

My use case involves updating the control’s displayed date based on a few factors, and I’m currently using the setup(withInitiallySelectedDate:) method, which works but has an overhead of having to repeat all the setup each time you update.

Would it be reasonable to either move the setup code to init and replace the current setup method with a setDate, or to add a setDate method which does just the date-setting stuff?

I’d be happy to put together a PR if either of these sound agreeable to you 😄

@calda
Copy link
Owner

calda commented May 27, 2019 via email

@calda
Copy link
Owner

calda commented May 27, 2019 via email

@Reza-Rajabi
Copy link

Hi.
I work on this if it's OK.

@calda
Copy link
Owner

calda commented Oct 21, 2019

Sure, I’m happy to review a PR if you make one

@calda calda closed this as completed in a19fe8c Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants