Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enclosing fieldset's disabled attr does not disable polyfilled elements #88

Closed
bennypowers opened this issue Nov 13, 2022 · 2 comments · Fixed by #102
Closed

Enclosing fieldset's disabled attr does not disable polyfilled elements #88

bennypowers opened this issue Nov 13, 2022 · 2 comments · Fixed by #102
Assignees
Labels
bug Something isn't working

Comments

@bennypowers
Copy link
Contributor

bennypowers commented Nov 13, 2022

Please consider https://codepen.io/bennyp/pen/KKemLEG?editors=1010

<form id="form">
  <fieldset id="set" disabled>
    <legend>This fieldset controls <code>x-checkbox</code></legend>
    <label for="xcheck">Check?</label>
    <x-checkbox id="xcheck" name="checkit"></x-checkbox>
  </fieldset>
</form>

In this case, using GNOME Web 43.0-66-g2cd7f8ec4+ (WebKitGTK 2.38.2), with the polyfill loaded, I observed that toggling disabled on the fieldset had no effect on x-checkbox.

Expected: :disabled or known-limitations equivalent should be applied to the FACE, mouse clicks should be prevented.

@calebdwilliams calebdwilliams added the bug Something isn't working label Nov 17, 2022
@calebdwilliams
Copy link
Owner

I'll try to work on this a bit unless you'd like to tackle it.

@bennypowers
Copy link
Contributor Author

I can grab this one:

the MutationObserver will toggle the string value of aria-disabled on each associated child when fieldset parent's disabled changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants