Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hydrate to $lifecycleHooks of component #149

Merged
merged 1 commit into from Aug 8, 2019

Conversation

@faustbrian
Copy link
Contributor

commented Aug 8, 2019

1️⃣ Is this something that is wanted/needed? Did you create a feature-request issue first?
Yes and No

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.
No

3️⃣ Does it include tests if possible? (Not a deal-breaker, just a nice-to-have)
No

4️⃣ Please include a thorough description of the feature/fix and reasons why it's useful.
4c4a0ba introduced the hydrate lifecycle hook but didn't register it which results in Method XXX::hydrate does not exist. because the __call method doesn't catch the call.

The tests didn't catch this because the test file has an actual hydrate method defined.

5️⃣ Thanks for contributing! 🙌

@calebporzio calebporzio merged commit c02d5e2 into calebporzio:master Aug 8, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@calebporzio

This comment has been minimized.

Copy link
Owner

commented Aug 8, 2019

Shoot, good call - thanks - patch released: v0.2.1

@faustbrian faustbrian deleted the faustbrian:patch-1 branch Aug 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.