New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Daily video calls #542
Daily video calls #542
Conversation
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Someone is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Hi @lunchpaillola , thanks for the great work. I have some feedback if you don't mind :) I believe we could use already available "isdedicated" concept and avoid hard coding an external provider (ie Daily here) in the event manager (and other places). For the db side, I would also suggest having a separate table to hold Daily's info and reference the booking id. Core tables shall theoretically be clean of external providers, to allow for better future evolutions. About migrations, it would be best to have just one migration per PR. You could prepare it by going from a base DB (from latest main branch) and the applying your schema and then generating the migration) For the emails templates, we could condition the meeting username and password existence and so avoid the hard coded provider condition. Also, I would suggest having another PR for code indentation fixes and lib/deps updates. I would love to see your PR merged soon :) |
Thanks for your review and the comments! |
968a6f2
to
d52a14f
Compare
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 2.2.14 to 2.2.15. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/master/CHANGELOG.md) - [Commits](tailwindlabs/tailwindcss@v2.2.14...v2.2.15) --- updated-dependencies: - dependency-name: tailwindcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
d52a14f
to
ac2dff3
Compare
…ailwindcss-2.2.15 ⬆️ Bump tailwindcss from 2.2.14 to 2.2.15
6c4976b
to
8471371
Compare
5f53a1b
to
23d9a72
Compare
23d9a72
to
e79b290
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good to me, will do some local testing now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! @lunchpaillola
Would you kindly add instructions on how to setup the integration like the other ones in the README.md?
EDIT: I've stumbled upon this error when trying to test it locally:
EDIT 2: Also, can we type cast this so we know what properties to expect from the response?
e79b290
to
dea725d
Compare
…erences to Daily.co video
…es in the event manager
861ca73
to
efe2e6c
Compare
Adding Daily Video Calls to Calendso. Here's a demo of what creating and joining a video room looks like
`https://www.loom.com/share/f1fe710a081a46078621749d532a6e1c```