feat: add translations for emails and type error fixes overall #994
Conversation
mihaic195
commented
Oct 19, 2021
•
mihaic195
commented
- I still need to translate the dates displayed in emails (day and month), but it's already hard to follow the PR. We can do it in a follow-up PR.
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/cal/calendso/4fA4zjNPmgGio5YGAPMaP5cEDyY8 |
…ndso/calendso into i18n/i18n-extract-strings-2
mihaic195
changed the title
| @@ -157,7 +159,7 @@ export default function ForgotPassword({ csrfToken }) { | |||
| ); | |||
| } | |||
|
|
|||
| ForgotPassword.getInitialProps = async (context) => { | |||
| ForgotPassword.getInitialProps = async (context: GetServerSidePropsContext) => { | |||
There was a problem hiding this comment.
Isn't getInitialProps deprecated?
There was a problem hiding this comment.
Indeed it should be changed!
mihaic195
changed the title
mihaic195
changed the title
| constructor( | ||
| calEvent: CalendarEvent, | ||
| uid: string, | ||
| videoCallData: VideoCallData, | ||
| additionInformation: AdditionInformation = null | ||
| ) { | ||
| super(calEvent, uid); | ||
| this.videoCallData = videoCallData; | ||
| this.additionInformation = additionInformation; | ||
| } | ||
|
|
There was a problem hiding this comment.
Not anymore. Everything is on calEvent 😁
| @@ -38,14 +33,22 @@ export default class CalEventParser { | |||
| * Returns a unique identifier for the given calendar event. | |||
| */ | |||
| public getUid(): string { | |||
| return this.maybeUid ?? translator.fromUUID(uuidv5(JSON.stringify(this.calEvent), uuidv5.URL)); | |||
| return this.calEvent.uid ?? translator.fromUUID(uuidv5(JSON.stringify(this.calEvent), uuidv5.URL)); | |||
There was a problem hiding this comment.
Can the calEvent contain dates and stuff? Then this would (wrongly?) give a new unique id if the event is rescheduled
Not sure if it matters at all.
Can use lodash/pick to pick the things you wan to make the uuid-hash based on
There was a problem hiding this comment.
I've moved most of the dangling stuff into the calEvent. I've specifically tested this flow to make sure that the uid is only there when rescheduling or updating a booking. Otherwise, it will be a new uid.
