Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Adblocker #48

Merged
merged 8 commits into from
Apr 18, 2019
Merged

🚧Adblocker #48

merged 8 commits into from
Apr 18, 2019

Conversation

benschwarz
Copy link
Member

@benschwarz benschwarz commented Apr 17, 2019

Adds adblocker to CLI & Node.js API

Single page tests
Use the --adblocker flag to test with adblocker

Options for updating a test profile

  • Use --no-javascript or --javascript to turn JS on/off for a profile
  • Use --no-adblocker or --adblocker to turn adblocking on or off for a profile

Listing test profiles with adblocker present
image

Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11876 lines exceeds the maximum allowed for the inline comments feature.

@benschwarz benschwarz mentioned this pull request Apr 18, 2019
10 tasks
Copy link

@codeclimate codeclimate bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 11889 lines exceeds the maximum allowed for the inline comments feature.

@codeclimate
Copy link

codeclimate bot commented Apr 18, 2019

Code Climate has analyzed commit 0233a76 and detected 0 issues on this pull request.

View more on Code Climate.

@benschwarz
Copy link
Member Author

This also switches to using Alpine for docker builds, because it's smaller and faster.

@benschwarz
Copy link
Member Author

@micdijkstra Merging this now, going to track other items for 2.0 in #49 and other PRs 👍

@benschwarz benschwarz merged commit e2739b2 into master Apr 18, 2019
@benschwarz benschwarz deleted the ad-blocker branch April 18, 2019 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant