Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add support for gif #37

Closed
chenrui333 opened this issue Jan 5, 2020 · 3 comments
Closed

Feature Request: Add support for gif #37

chenrui333 opened this issue Jan 5, 2020 · 3 comments

Comments

@chenrui333
Copy link

@chenrui333 chenrui333 commented Jan 5, 2020

No description provided.

@benschwarz

This comment has been minimized.

Copy link
Member

@benschwarz benschwarz commented Jan 7, 2020

Thanks for logging this @chenrui333. I'm not quite sure where we'd start with GIF compression to be honest. It's almost never the best image format for motion graphics.

Any effort that would be made to better compress a GIF would be to drop the framerate, or reduce the colour palette or other lossy enhancements.

That doesn't feel like something you'd set and forget for a whole repo (without being able to configure it a lot), which is kind of the whole point of image-actions.

What do you think about all that?

@benschwarz

This comment has been minimized.

Copy link
Member

@benschwarz benschwarz commented Jan 15, 2020

Closing due to lack of feedback, feel free to re-start the conversation

@benschwarz benschwarz closed this Jan 15, 2020
@chenrui333

This comment has been minimized.

Copy link
Author

@chenrui333 chenrui333 commented Jan 15, 2020

Yeah, sorry for getting back late on this. I am less familiar with the image compression tooling than I should, we were using imagemin-lint-staged plugin (which does gif impression) before, so I was curious whether it would be possible to add gif support in here.

Let me know if that makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.