From db5dd249c7aa21a585ff659425c5c741e40cc1aa Mon Sep 17 00:00:00 2001 From: Laurent David Date: Mon, 7 Nov 2022 15:11:48 +0100 Subject: [PATCH 1/2] Fix camel case in strings Fix issue #2 --- lang/en/block_featured_courses.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lang/en/block_featured_courses.php b/lang/en/block_featured_courses.php index 7740ff7..7e6ad64 100644 --- a/lang/en/block_featured_courses.php +++ b/lang/en/block_featured_courses.php @@ -26,6 +26,6 @@ $string['config:selectedcourses'] = 'Selected course {no}'; $string['featured_courses:addinstance'] = 'Add a featured_courses block'; $string['featured_courses:myaddinstance'] = 'Add a featured_courses block to my moodle'; -$string['pluginname'] = 'Featured Courses'; +$string['pluginname'] = 'Featured courses'; $string['removelastcourses'] = 'Remove last course'; -$string['viewcourse'] = 'View Course'; +$string['viewcourse'] = 'View course'; From bc331181342cccac427d7b2706efe9cd6fe0d8bf Mon Sep 17 00:00:00 2001 From: Laurent David Date: Mon, 7 Nov 2022 15:22:25 +0100 Subject: [PATCH 2/2] Fix issue with behat * Fix readme link * Use I press "Customise this page" instead of I turn editing on --- README.md | 4 +--- tests/behat/block_featured_courses.feature | 10 +++++----- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 7c548fa..df0a2fa 100644 --- a/README.md +++ b/README.md @@ -1,8 +1,6 @@ # Featured courses # -[![Moodle Plugin CI](https://github.com/martin-call-learning/moodle-block_featured_courses/actions/workflows/main.yml/badge.svg)](https://github.com/martin-call-learning/moodle-block_featured_courses/actions/workflows/main.yml) - -[![Build Status](https://travis-ci.org/call-learning/moodle-block-featured_courses.svg?branch=master)](https://travis-ci.org/call-learning/moodle-block-featured_courses) +[![Moodle Plugin CI](https://github.com/call-learning/moodle-block_featured_courses/actions/workflows/main.yml/badge.svg)](https://github.com/call-learning/moodle-block_featured_courses/actions/workflows/main.yml) A block to display of courses from the global list of courses. diff --git a/tests/behat/block_featured_courses.feature b/tests/behat/block_featured_courses.feature index 94f4620..c1189fa 100644 --- a/tests/behat/block_featured_courses.feature +++ b/tests/behat/block_featured_courses.feature @@ -14,9 +14,9 @@ Feature: Add a featured block on the dashboard Scenario: Add the block and set 3 featured courses Given I log in as "admin" Then I am on homepage - And I turn editing mode on + When I press "Customise this page" And I add the "Featured Courses" block - And I configure the "Featured Courses" block + And I configure the "Featured courses" block And I expand all fieldsets Then I should see "Title" And I set the field "Title" to "My featured courses" @@ -34,9 +34,9 @@ Feature: Add a featured block on the dashboard @javascript Scenario: Add the block and set 3 featured courses and remove one after, only two should display Given I log in as "admin" - Then I turn editing mode on - And I add the "Featured Courses" block - And I configure the "Featured Courses" block + When I press "Customise this page" + Then I add the "Featured courses" block + And I configure the "Featured courses" block And I expand all fieldsets Then I should see "Title" And I set the field "Title" to "My featured courses"