[Popover] Implement ability to pass coordinates as anchor #9004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackyho112
changed the title
jackyho112
changed the title
oliviertassinari
force-pushed
the
implement-ability-to-pass-coordindates-as-anchor-for-popover
branch
from
25bc88a
to
19324c8
Compare
oliviertassinari
force-pushed
the
implement-ability-to-pass-coordindates-as-anchor-for-popover
branch
from
19324c8
to
c2cfbf7
Compare
|
@jackyho112 This is a high-quality pull request. Thank you! |
jackyho112
deleted the
implement-ability-to-pass-coordindates-as-anchor-for-popover
branch
the-noob
pushed a commit
to the-noob/material-ui
that referenced
this pull request
Nov 17, 2017
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #8711, so that the Popover component takes an
anchorPositionprop and ananchorReferenceprop to allow setting the position of the popover on just coordinates in addition to an HTML element.An example:
Not sure if that was clear. Let me know if I miss anything or how I can improve this PR. Look forward to any feedback. 馃槃
Closes #8711