Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clever code distracts from actual example. #2

Merged
merged 1 commit into from Feb 3, 2017

Conversation

@ccoenen
Copy link
Contributor

commented Feb 3, 2017

Example code should be as clear as possible and focus on the task being shown. In my opinion there is really no point in using the reduce-construct.

Clever code distracts from actual example.
Example code should be as clear as possible and focus on the task being shown. In my opinion there is really no point in using the reduce-construct.
@callmecavs

This comment has been minimized.

Copy link
Owner

commented Feb 3, 2017

@ccoenen imo the reduce function doesn't qualify as "overly-clever" (i prefer to keep selecting elements as DRY as possible) - but I do see your point in that it doesn't help illustrate the capabilities of the library at all.

happy to merge this in, but could you do me a favor and remove the ;? gotem follows standard style, and for consistencies sake the README should to

@callmecavs callmecavs merged commit 01ce97e into callmecavs:master Feb 3, 2017

@callmecavs

This comment has been minimized.

Copy link
Owner

commented Feb 3, 2017

@ccoenen nvm, I'll fix it when I bump the version number. thanks dude!

@ccoenen

This comment has been minimized.

Copy link
Contributor Author

commented Feb 3, 2017

thanks for the heads up, I'll be more careful with code style next time.

@callmecavs

This comment has been minimized.

Copy link
Owner

commented Feb 3, 2017

just the README so its not a big deal haha, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.