Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent async imports from creating chunks

Conversation

hedgepigdaniel
Copy link
Contributor

@hedgepigdaniel hedgepigdaniel commented Feb 20, 2020

Summary

Fixes #701

Test plan

@zamotany
Copy link
Member

zamotany commented Feb 21, 2020

Thanks for the PR, looks good, but I need to check the failing tests. I suspect it's because of assertion that doesn't make sense now. Basically it was checking if the following regex is matched in the bundle:

/return asyncEval\(__webpack_require__\.p \+ "" \+ chunkId \+ "\.app1\.(ios|android)\.bundle"\);/g

but if the modules from chunk are inside the bundle, this code will never be created. Also we can probably remove code that add asyncEval helper functions.

@zamotany zamotany changed the base branch from master to fix/use-signle-chunk Mar 2, 2020
@zamotany zamotany merged commit 05ac921 into callstack:fix/use-signle-chunk Mar 2, 2020
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants