fix: fix type error with a component interpolation #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @hemmxwxsoo, thank you for your pull request 🤗. |
|
Looks like we need some kind of // ts-ignore comment on that line so the CI passes |
|
Sorry @satya164 but I think there may be a problem with that code. But I'm not sure. If I have a code below. export const Form = styled.form`
color: red;
`;
export const Input = styled.input`
${Form}:hover & {
width: 1px;
}
`;Then React.FunctionComponent<React.ClassAttributes<HTMLFormElement> & React.FormHTMLAttributes<HTMLFormElement> & {
as?: "symbol" | "object" | "a" | "abbr" | "address" | "area" | "article" | "aside" | ... 166 more ... | undefined;
}>instead of React.FunctionComponent<React.ClassAttributes<HTMLInputElement> & React.InputHTMLAttributes<HTMLInputElement> & {
as?: "symbol" | "object" | "a" | "abbr" | "address" | "area" | "article" | "aside" | ... 166 more ... | undefined;
}>I tried to made it but I don't know what is wrong. 😥 |
Esemesek
reviewed
Apr 3, 2019
| @@ -13,7 +13,7 @@ type StyledComponent<T> = React.StatelessComponent< | |||
| type StyledTag<T> = <Props = T>( | |||
| strings: TemplateStringsArray, | |||
| ...exprs: Array< | |||
| string | number | CSSProperties | ((props: Props) => string | number) | |||
| string | number | CSSProperties | ((props: Props) => string | number) | StyledComponent<any> | |||
There was a problem hiding this comment.
Can you add a test case that would cover broken ts definitions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It allows using component interpolation without typescript error. (#370)