Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][webpack] Use hash in CSS filename #472

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@Daniel15
Copy link
Contributor

commented Aug 12, 2019

Summary

Best practice for Webpack assets is to include a hash in the filename. This allows far future expires headers to be used, as the filename changes whenever the contents change.

Test plan
馃憖

@Daniel15 Daniel15 changed the title Use hash in CSS filename [docs][webpack] Use hash in CSS filename Aug 12, 2019

@callstack-bot

This comment has been minimized.

Copy link

commented Aug 12, 2019

Hey @Daniel15, thank you for your pull request 馃.
The coverage report for this branch can be viewed here.

@thymikee
Copy link
Member

left a comment

LGTM!

@thymikee thymikee merged commit 4acde48 into callstack:master Aug 12, 2019

4 checks passed

ci/circleci: install-dependencies Your tests passed on CircleCI!
Details
ci/circleci: lint-and-typecheck Your tests passed on CircleCI!
Details
ci/circleci: lint-website Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.