Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Import custom identifier called css with error "Cannot find module 'linaria'" #739 #740

Merged
merged 2 commits into from Mar 20, 2021

Conversation

GitaiQAQ
Copy link
Contributor

Motivation

#739

Summary

When import css from some module like './utils', webpack will throw an error "Cannot find module 'linaria'"

import { css } from './utils';

...

Because the package 'linaria' is deprecated, At here try the resolve this. And then require.resolve will throw an exception.

Test plan

use this case https://codesandbox.io/s/linaria-demo-forked-rbivr?file=/src/index.js

@callstack-bot
Copy link

Hey @GitaiQAQ, thank you for your pull request 🤗.
The coverage report for this branch can be viewed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants