From 4b06ca32c6520e559cceec1dacbbf1d69a96e34d Mon Sep 17 00:00:00 2001 From: artus9033 Date: Thu, 15 Jan 2026 19:18:49 +0100 Subject: [PATCH] refactor: rename __getStore global JS var to __brownieGetStore to reduce 3p globals collision risk --- packages/brownie/cpp/BrownieInstaller.cpp | 4 ++-- packages/brownie/src/index.ts | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/brownie/cpp/BrownieInstaller.cpp b/packages/brownie/cpp/BrownieInstaller.cpp index 39d3a477..0437eddd 100644 --- a/packages/brownie/cpp/BrownieInstaller.cpp +++ b/packages/brownie/cpp/BrownieInstaller.cpp @@ -6,7 +6,7 @@ namespace brownie { void BrownieInstaller::install(facebook::jsi::Runtime &runtime) { auto getStore = facebook::jsi::Function::createFromHostFunction( - runtime, facebook::jsi::PropNameID::forAscii(runtime, "__getStore"), 1, + runtime, facebook::jsi::PropNameID::forAscii(runtime, "__brownieGetStore"), 1, [](facebook::jsi::Runtime &rt, const facebook::jsi::Value &, const facebook::jsi::Value *args, size_t count) -> facebook::jsi::Value { if (count < 1 || !args[0].isString()) { @@ -25,7 +25,7 @@ void BrownieInstaller::install(facebook::jsi::Runtime &runtime) { return facebook::jsi::Object::createFromHostObject(rt, hostObject); }); - runtime.global().setProperty(runtime, "__getStore", getStore); + runtime.global().setProperty(runtime, "__brownieGetStore", getStore); } } // namespace brownie diff --git a/packages/brownie/src/index.ts b/packages/brownie/src/index.ts index 01865ff4..6b045126 100644 --- a/packages/brownie/src/index.ts +++ b/packages/brownie/src/index.ts @@ -23,7 +23,7 @@ const stores = new Map(); function getHostObject(key: string): HostObject { // @ts-expect-error - untyped global prop set by BrownieInstaller.cpp - return global.__getStore?.(key); + return global.__brownieGetStore?.(key); } function getOrCreateStore(key: string): StoreCache {