Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make year dynamic #354

Merged
merged 1 commit into from
Feb 7, 2023
Merged

feat: make year dynamic #354

merged 1 commit into from
Feb 7, 2023

Conversation

dcangulo
Copy link
Contributor

Summary

We are manually updating year when it can be dynamic.

Test plan

  • The following command should not fail.
node packages/create-react-native-library/bin/create-react-native-library sample-module
  • Year in LICENSE should be the device's year.

atlj
atlj requested changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@atlj atlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! thank you for the PR left a small nit 🚀

packages/create-react-native-library/src/index.ts Outdated Show resolved Hide resolved
@dcangulo
Copy link
Contributor Author

dcangulo commented Feb 4, 2023

@atlj Updated

atlj
atlj approved these changes Feb 4, 2023
View reviewed changes
Copy link
Collaborator

@atlj atlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much for the PR. 🚀🚀

@atlj
Copy link
Collaborator

atlj commented Feb 4, 2023

Please feel free to merge

@atlj atlj merged commit 8795a94 into callstack:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlj atlj atlj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcangulo @atlj