Skip to content

Conversation

@retyui
Copy link
Collaborator

@retyui retyui commented Nov 1, 2023

Summary

Setup Github Actions

  • eslint
  • flow
  • cache
  • Android build (multiple versions next->0.73.0-rc.3, latest->0.72.6, 0.71-stable->0.71.14)
  • iOS buid (multiple versions: next->0.73.0-rc.3, latest->0.72.6, 0.71-stable->0.71.14)

Test plan

Tested on my fork: https://github.com/retyui/react-native-image-editor/actions/runs/6718981645

@retyui retyui force-pushed the github-actions-setup branch from e38f035 to ff60148 Compare November 1, 2023 11:14
@thymikee
Copy link
Member

thymikee commented Nov 2, 2023

Awesome! I think it would be enough to test the build on the latest RN version. Although 3 seem nice, it sounds like overkill for this library (making the test runs last 30+ min instead of 10-ish)

Signed-off-by: David <4661784+retyui@users.noreply.github.com>
@retyui retyui force-pushed the github-actions-setup branch from ff60148 to 762713f Compare November 2, 2023 09:20
@retyui
Copy link
Collaborator Author

retyui commented Nov 2, 2023

Good point!

@retyui retyui merged commit ded48e5 into callstack:master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants