Improve CPU hotspot explainability for repeated work#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent-cdp users can now tell whether a CPU hotspot's cost came from repeated short runs, delegated child work, or inclusive total time without exporting the raw profile to another tool.
Summary
--min-total-mstoprofile cpu hotspotsso inclusive-time filtering matches the existing self-time filterprofile cpu hotspotwith repeated-run summaries, delegated child time, top callers/callees, and exact hotspot bucket distributionBackward Compatibility
profile cpu hotspottext output exactly; the command is still the same, but the human-readable lines are richer.Risks
profile cpu hotspottext formatting may need to adjust.Fixes #18
Manual Testing
agent-cdp profile cpu hotspots --sort totalMs --min-total-ms 50and verify that inclusive-time filtering surfaces hotspots whose cost mostly lives in children.agent-cdp profile cpu hotspot --id HOTSPOT_ID; verify that the output calls out repeated runs, delegated child time, top callers/callees, and active time ranges.--verboseand verify that the extra explanatory fields remain sample-based summaries rather than exact timing claims.