Skip to content

Conversation

@giomsilva
Copy link
Contributor

@giomsilva giomsilva commented Nov 12, 2025

PR Description

Bug fix - Fixed C++ compilation error caused by an uncommented TODO line in RCTBottomAccessoryComponentView.mm that was preventing release builds from succeeding. Preventing us to use renderBottomAccessoryView.

How to test?

  1. Build the iOS app in release mode

  2. Verify the build completes successfully without compilation errors

  3. Use the renderBottomAccessoryView prop on TabView:
    import { TabView } from 'react-native-bottom-tabs';
    <TabView renderBottomAccessoryView={() => } />

  4. Verify the bottom accessory view renders and layout events emit correctly

Screenshots

image image

Note

Comments an unintended TODO in RCTBottomAccessoryComponentView.mm that broke release builds and updates Podfile.lock to react-native-bottom-tabs 1.0.2.

  • iOS Native (react-native-bottom-tabs):
    • Comment out stray TODO in packages/react-native-bottom-tabs/ios/RCTBottomAccessoryComponentView.mm to restore compilation; onNativeLayout emission remains unchanged.
  • Dependencies:
    • Update apps/example/ios/Podfile.lock to react-native-bottom-tabs 1.0.2 (and common), with related checksum changes.

Written by Cursor Bugbot for commit 440b6ee. This will update automatically on new commits. Configure here.

@changeset-bot
Copy link

changeset-bot bot commented Nov 12, 2025

⚠️ No Changeset found

Latest commit: 440b6ee

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@okwasniewski okwasniewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing that! That's crazy that it snaked in there 😅

@okwasniewski okwasniewski merged commit b626480 into callstackincubator:main Nov 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants