From 7685e01a1555663b356fd3ea8185d4823395a67b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kr=C3=A6n=20Hansen?= Date: Tue, 4 Nov 2025 09:22:29 +0100 Subject: [PATCH] Remove --force from vendor hermes command --- .changeset/tender-laws-admire.md | 5 +++++ packages/host/android/build.gradle | 2 +- packages/host/src/node/gradle.test.ts | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/tender-laws-admire.md diff --git a/.changeset/tender-laws-admire.md b/.changeset/tender-laws-admire.md new file mode 100644 index 00000000..4aa54b2b --- /dev/null +++ b/.changeset/tender-laws-admire.md @@ -0,0 +1,5 @@ +--- +"react-native-node-api": patch +--- + +Don't instruct users to pass --force when vendoring hermes diff --git a/packages/host/android/build.gradle b/packages/host/android/build.gradle index 169265a0..41c7b7bd 100644 --- a/packages/host/android/build.gradle +++ b/packages/host/android/build.gradle @@ -7,7 +7,7 @@ if (!System.getenv("REACT_NATIVE_OVERRIDE_HERMES_DIR")) { "React Native Node-API needs a custom version of Hermes with Node-API enabled.", "Run the following in your Bash- or Zsh-compatible terminal, to clone Hermes and instruct React Native to use it:", "", - "export REACT_NATIVE_OVERRIDE_HERMES_DIR=\$(npx react-native-node-api vendor-hermes --silent --force)", + "export REACT_NATIVE_OVERRIDE_HERMES_DIR=\$(npx react-native-node-api vendor-hermes --silent)", "", "And follow this guide to build React Native from source:", "https://reactnative.dev/contributing/how-to-build-from-source#update-your-project-to-build-from-source" diff --git a/packages/host/src/node/gradle.test.ts b/packages/host/src/node/gradle.test.ts index 9dcb218c..e08ee16e 100644 --- a/packages/host/src/node/gradle.test.ts +++ b/packages/host/src/node/gradle.test.ts @@ -38,7 +38,7 @@ describe( ); assert.match( stderr, - /export REACT_NATIVE_OVERRIDE_HERMES_DIR=\$\(npx react-native-node-api vendor-hermes --silent --force\)/, + /export REACT_NATIVE_OVERRIDE_HERMES_DIR=\$\(npx react-native-node-api vendor-hermes --silent\)/, ); assert.match( stderr,