fix(network-activity-plugin): isolate react-native-nitro-fetch into separate bundle chunk#260
Merged
Merged
Conversation
…eparate bundle chunk Mitigates facebook/metro#836 where Metro fails to resolve optional dependencies even when wrapped in try/catch. Moves the `require('react-native-nitro-fetch')` call into a dedicated `get-nitro-module.ts` file so Vite can split it into its own chunk, matching the existing pattern used for `react-native-sse` / `event-source.ts`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Metro has a known issue (facebook/metro#836) where optional
require()calls fail to resolve correctly even when wrapped intry/catch. This causedreact-native-nitro-fetch— an optional dependency — to break bundling in some Metro configurations.Solution
Follows the same pattern already in place for
react-native-sse/event-source.ts:require('react-native-nitro-fetch')call fromnitro-network-inspector.tsinto a dedicatedget-nitro-module.tsfile.get-nitro-module.tsto Vite'smanualChunksso Rollup emits it as a separate bundle chunk.Metro loads each chunk independently, which sidesteps the optional-dependency resolution bug.
Changes
src/react-native/nitro-fetch/get-nitro-module.ts— new file with the isolatedgetNitroModulegetternitro-network-inspector.ts— removesloadNitroModule, imports from the new file; exportsNitroModuletypevite.config.ts— addsget-nitro-module.tstomanualChunks.changeset/nitro-fetch-optional-dep-chunk.md— patch changeset