Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On install comments should be off #105

Closed
markkap opened this Issue Sep 30, 2018 · 1 comment

Comments

Projects
None yet
1 participant
@markkap
Copy link

markkap commented Sep 30, 2018

While the chances of anyone getting spam before he gets a chance to turn comments off, are zero, in principal you should not have end points which can be abused active by default.

On fresh install comments should simply be off. At that state it is probably best to hide the discussion settings and the comments related admin (also in the post edit screen).

@markkap markkap added the spam label Sep 30, 2018

@markkap markkap added this to the 1.0.0 milestone Sep 30, 2018

@markkap markkap added the comments label Oct 10, 2018

@markkap

This comment has been minimized.

Copy link
Author

markkap commented Apr 18, 2019

After spending some time to figure out what does it mean having comments off, especially when they are turned off after the site was installed in which case a user might still want to display comments, got to a decision that for now, it would be enough to turn the default to closed instead of open. This will be good enough for SMB type of sites as while comment related information might still add noise to post admin, it is off by default which means that the main UI bloat is the comments menu, which we can hide if there are no comments to manage at all (need to check the performance implications of adding such a check)

@markkap markkap closed this in 014bada Apr 18, 2019

markkap added a commit that referenced this issue Apr 18, 2019

markkap added a commit that referenced this issue Apr 18, 2019

markkap added a commit that referenced this issue Apr 18, 2019

markkap added a commit that referenced this issue Apr 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.