Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the manual post excerpt functionality into a core plugin #114

Closed
markkap opened this issue Oct 4, 2018 · 2 comments
Closed

Move the manual post excerpt functionality into a core plugin #114

markkap opened this issue Oct 4, 2018 · 2 comments

Comments

@markkap
Copy link

@markkap markkap commented Oct 4, 2018

The manual post excerpt is a weird thing. One the one hand it is promoted as a way to provide a simple and short textual summery of the post, but on the other it accepts HTML if the user has an unfiltered_html capability for the post (and multisite users don't have such capability).
In addition it is hidden by default.

The reason to not just deprecate it is that register_post_type allows the developer to request the manual excerpt to be displayed in the post editing screen for that post type, and there might be some code in the wild that rely on it to be there.

The change in core for 1.0.0 should probably include a deprecation notice for the use of the parameter if the core plugin do not exist.

@markkap
Copy link
Author

@markkap markkap commented Apr 27, 2019

Since excerpt is one of the parameters for detecting changes in revision, that code is also changed to ignore the excerpt. The plugin does not bring back the functionality.

Loading

@markkap
Copy link
Author

@markkap markkap commented Apr 28, 2019

Loading

@markkap markkap closed this Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant