Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An admin should be able to edit the .htaccess file from the admin itself #236

Closed
markkap opened this issue Mar 12, 2019 · 3 comments
Closed

An admin should be able to edit the .htaccess file from the admin itself #236

markkap opened this issue Mar 12, 2019 · 3 comments
Labels
Milestone

Comments

@markkap
Copy link

@markkap markkap commented Mar 12, 2019

Right now the only way a user can modify the .htaccess file is by using an (S)FTP software, or access via SSH. When a user does so he is editing the whole file including the autogenerated section.

It would be better to let the user have more limited control by introducing a user-specific section in the .htaccess file and let him edit only that section.

With everything done from the admin, we can have a robust backup, test and recovery implementation, something the user is less likely to do right by himself.

This will be implemented in a dedicated admin screen, one which will be used to also handle saving the .htaccess file when plugin and/or core change an automated section.

Future enhancements might include some explicit control over the core section over things like browser caching time.

@markkap markkap added the apache label Mar 12, 2019
@markkap markkap added this to the 1.0.0 milestone Mar 12, 2019
@markkap
Copy link
Author

@markkap markkap commented Mar 19, 2019

Although there is a temptation to just delete the code that tries to automatically save the .htaccess file when entering the permalinks window, for now, will avoid removing it as it is expected functionality

Loading

markkap added a commit that referenced this issue Apr 1, 2019
markkap added a commit that referenced this issue Apr 8, 2019
markkap added a commit that referenced this issue Apr 10, 2019
markkap added a commit that referenced this issue Apr 10, 2019
markkap added a commit that referenced this issue Apr 12, 2019
… information, generating form to gather it and parse the request for it/ Part of #236
markkap added a commit that referenced this issue Apr 12, 2019
markkap referenced this issue Apr 12, 2019
@markkap markkap closed this Apr 12, 2019
@markkap
Copy link
Author

@markkap markkap commented Apr 14, 2019

Still missing functionality to revert changes if saving the .htaccess file broke something obvious.

Loading

@markkap markkap reopened this Apr 14, 2019
@markkap
Copy link
Author

@markkap markkap commented Aug 23, 2021

Closed after improvment in getting FTP credentials and adjusting the UI to use it.

Loading

@markkap markkap closed this Aug 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant